Services/Process/Code Review

Code Review Policy for Mozilla Services Code

Code review prior to landing is now required for _all_ changes to all production-oriented Mozilla Services code. This includes the Firefox Sync client code, the various pieces of server code, and anything else living in http://hg.mozilla.org/services.

All changes must have at least one review, and all large changes (significant refactorings, new features, new codebases) must have at least two reviews from qualified reviewers. Where it is unclear, the first reviewer should determine that a second review would be appropriate.

Code Areas

Firefox Sync

Repositories

• services-central
• fx-sync (now defunct)

Reviewers

• Richard Newman
• Greg Szorc
• Mike Connor
• Philipp von Weitershausen

Android Sync

No formal code review policy yet. :rnewman owns this one.

Firefox Share (f.k.a. F1)

Repositories

• fx-share

Reviewers

• Philipp von Weitershausen
• Shane Caraveo

Identity client

Repositories

• Identity-Server/static

Reviewers

• Richard Newman :rnewman
• JR Conlin :jconlin

Server Code (PHP)

Repositories

• Sync Server
• Registration Server
• Registration Server (Secure)

Reviewers

• Toby Elliott
• Tarek Ziade
• JR Conlin
• Mike Connor

Sync/Reg Server Code (Python)

Repositories

• Core Functions (Shared)
• Registration Code
• Storage API Code
• Full Server server-full is a meta-package that pulls in all components needed for a standalone server

Reviewers

• Tarek Ziade
• Toby Elliott
• JR Conlin
• Ian Bicking

Key Exchange Server (Python)

Repositories

• Key Exchange

Reviewers

• Tarek Ziade
• Toby Elliott
• JR Conlin
• Ian Bicking

Identity server

Repositories

• Identity Server

Reviewers

• JR Conlin :jconlin
• Toby Elliott :telliot
• Tarek Ziade :tarek