Firefox/Meeting/21-Nov-2017
From MozillaWiki
Today’s meeting leader is: jaws
Contents
- 1 General Topics / Roundtable
- 2 Friends of the Firefox team
- 3 Project Updates
- 4 Meeting Leader Rotation
General Topics / Roundtable
- Firefox 57 has been released! 🎉🎆🎉🎆🎉🎆🎉🎆🎉🎆
- [mconley] Martin Stránský [:stransky] from RedHat has landed patches that allow us to (finally!) draw tabs in the titlebar on GNOME! Controlled by widget.allow-client-side-decoration pref for now.
- This should now be working on Ubuntu and (probably) Fedora as well
- Still lots of bugs to fix before turning it on by default can be considered
- Here’s the metabug
- [mconley] I added a chrome-only “scrollend” event. Does what it says on the tin.
- [mconley] SearchFox now shows image icons when listing directories, and a SVG previews when showing code for an SVG.
- [johannh] On Windows, you can use the touchdownstartsdrag attribute to make your draggable elements touch-compatible (in the chrome process).
Friends of the Firefox team
(Give a shoutout/thanks to people for helping fix and test bugs. Introductions)
- Resolved bugs (excluding employees): https://mzl.la/2A1Fmaz
- More than one bug fixed:
- Aditya Bharti
- Tim Nguyen :ntim
- Tooru Fujisawa [:arai]
- New contributors (🌟 = First Patch!)
- 🌟 86ecce74 helped us get rid of an unneeded XBL binding! Great to see another binding bite the dust.
- 🌟 QuanTakeuchi removed the unused mIconLoadingPricipal field!
Project Updates
Add-ons
- Fixed some bugs with the browser.identity.launchWebAuthFlow API.
- Fixed a crash with webRequest.filterResponseData.
- The theme API now has support for colors.tab_text and colors.background_tab_text and can accept both Chrome arrays and CSS colors for all properties.
- Custom context menus can now be added to bookmarks.
- Extensions can now programmatically register content scripts from a background page.
Activity Stream
- Running 2 experiments on release channel with 1% new and 2% existing get Tiles
- Added tippy top rich icon service to show icons that are better quality but only advertised by the site to iOS devices (including twitch to avoid thumbnailing…)
- Investigating background thumbnailing issues leading to twitch high CPU / MEDIA_ERR_SRC_NOT_SUPPORTED for youtube/twitch(/netflix?) for 57 users
- Turned on Pocket local personalization by default which takes the generic story feed and adjusts the ordering based on client-side computation of history / impressions
- Preparing for 59 MIT-licensed React 16 update and other dependency greening
Browser Architecture
- Sync and storage team have completed a roadmap review, look for more details in our next newsletter.
- Running mochitest-plain in headless mode is now supported on Windows, MacOS, and Linux. Use the “--headless” flag with “./mach test” to try it out.
- XBL removal is proceeding. No more XBL bindings in mobile!
- We have two meetings in Austin you should attend if you’re interested.
Firefox Core Engineering
- Bug 1409148 - The Flash Click-to-Play UI has been restyled to match Photon styling (landed for 58):
- Support for CFI-based stackwalking has finally landedand stuckin 59. This affects only the minidump analyzer (and related tests) but will improve the quality of stacks especially for 64bit, and so we’re requesting uplift to 58beta.
- Performance optimizations for import/migration are progressing and hope to land in 59.
- “Mozilla Firefox” -> “Firefox” rename riding on 58, assuming QA gives it a green.
- [mconley]: I thought this got backed out? (From 57 only, relanded as bug 1415647)
Form Autofill
- MVP
- Implemented the credit card updating mechanism (including the door hanger and deduplication rules)
- Fixed more compatible issues related to credit card expiration date (QVC, Sears, AliExpress, etc)
- Fixed a UI issue of the suggestion dropdown footer
- Fixed a few regression bugs
- Enabled Credit Card Autofill on Fx58 beta 5 (for users using en-US build and located in the US)
- Ready to increase the availability of Address Autofill on Fx57 from 1% to 20%
- Quantum release continues to get better! \o/
- V2
- [L10N] Made accesskeys in the door hangers localizable
- [L10N] Fixed a UI issue in preferences after localization
- [Clear Button] Feature complete and landed
- [Clear Button] Fixed an issue that the suggestion dropdown falsely uses cached result even the input value has been changed
- [CA/DE Support] Implemented a parser of libaddressinput for knowing which address fields in preferences should be visible in different countries
- [Section Support] Refactored FormAutofillHandler to support multiple section mechanism
- [Others] Fixed some minor issues related to ProfileStorage
Lint
- Using the pre-push hooks should now work better in git-cinnibar repositories.
- experimentalObjectRestSpread has been turned on in ESlint options - use Object Rest/Spread constructs.
- ESLint has been upgraded to v4.
- ESLint’s semi (semicolons required) rule is now enabled across the tree
Photon
Performance
- [mconley] Fixed a bug where we had regressed high-speed scrolling in the tab strip when switching to smooth-scroll
- [mconley] Tab warming slowly proceeding. Still fixing more test breakage.
- [florian] Join us for our elective in Austin for a retrospective of how we made Firefox faster, and discuss what we’ll do next: Photon Performance: How We Made Firefox Faster
Structure
- Paolo updated the identity popup cert/security subview to the new photon styling
- Markus Stange worked around a layers/gfx issue the panel animations were running into just before the 57 release (woop!).
- Jared & Gijs removed a bunch of dead code.
- Drew fixed an issue with disabling of page actions.
Animation
- Sam is working on extracting/polishing some of the SVG utilities we bodged together for the SVG animation work. Includes some SVGO plugins.
Visuals
- You can now drag (selected) tabs and items in customize mode using touch.
- Small finishing touches.
Privacy/Security
- The confirm repost prompt is no longer window modal.
- Gijs fixed up clock skew warnings on the cert error pages so that they are only shown when we’re sure they’re correct.
- We’ve started working on integrating haveibeenpwned.com warnings into Firefox, you can find the experimental add-on here.
Address Bar & Search
- Investigating frequent intermittent failures in the omnibox WebExtension test (there are more)
- Removed the code to import old search engine settings from Firefox 44 and before.
Places
- Work continued on improving Places Async Transactions reliability and performance
- Work continued on converting tests to the async Bookmarking APIs
- Examined recent SUMO reports about bookmarks loss, identified various possible reasons to evaluate for our reliability project
- Doug Thayer, while investigating reasons for slow migrations, largely improved the time needed to insert lots of visits at once. More fixes incoming in the next weeks!
- Kit Cambridge is improving annotations and bookmarks performance by removing an annotations observer from the bookmarks service. (blocked on a static analysis problem)
Sync / Firefox Accounts
- Edouard improved sync scheduling when we wake from sleep, reconnect to a flaky network or a network behind a captive portal, and before sleep.
- Edouard is also replacing Sync’s artisanal HTTP client with `fetch`.
- You can now pass a `{ mozErrors: true }` option to `fetch` and `Request` in chrome code to access the underlying `nsresult` code if the request fails.
- Thom fixed an issue where many sent tabs or bookmark repair responses would overflow the Sync client record size, causing all syncs for that client to permanently fail.
- We’re working with Emily Toop from the Browser Architecture team on a prototype for new storage and sync. We’ll have a demo ready for Austin!
Test Pilot
- We did an intense sprint to Photonize the website where we touched a huge percentage of the code, changing the styles and rearranging the directory structure of our react components so things are better componentized. The site was ready the day before the 57 launch, and it took a ton of effort from everybody.
- This sprint is focused on updating our dependencies which are very out of date, and cleaning up some old cruft.
Web Payments
- Made the dialog contents hackable from file: URIs for quick iteration
- Implemented the first Custom Element (currency-amount)
- Finishing up the store for dialog state that Custom Elements will listen to
- Starting to implement the UX spec
Meeting Leader Rotation
Add your name below if you want to be in the rotation of leaders:
- mconley
- johannh
- MattN
- kitcambridge
- jaws
- bsilverberg
- RyanVM
- mikedeboer
- felipe
- 6a68