Bugs

Bugs Taken in Planning

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Status	Resolution
967440	Anthony Ricaud (:rik)	Remove some reflows on the keypad	-	No cf_feature-b2g	[priority][planned-sprint c=3][in-sprint=v2.0-S6]	RESOLVED	FIXED
995938	David Garcia [:davidg][retired]	Device does not play an 'end tone' when the call is finished	---	No cf_feature-b2g	[priority][planned-sprint c=2]	VERIFIED	FIXED
998147	Tamara Hills [:thills]	[Dialer] A Missed Call notification is given when chosing to hang up on an incoming call	2.0+	No cf_feature-b2g	[tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6]	VERIFIED	FIXED
1006592	Gabriele Svelto [:gsvelto]	While sending USSD code, last dialed number by user appears in dialer app	2.0+	No cf_feature-b2g	[planned-sprint]	VERIFIED	FIXED
1010104	Germán Toro del Valle (:gtorodelvalle)	[Dialer][Call Screen] Baseline of the contact name when applying the fluid font size	---	No cf_feature-b2g	[planned-sprint c=1][in-sprint=v2.0-S6]	RESOLVED	FIXED
1015883	Gabriele Svelto [:gsvelto]	[Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario	-	No cf_feature-b2g	[planned-sprint c=3]	RESOLVED	FIXED
1023246	Paco Rampas [:paco]	[Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.	---	No cf_feature-b2g	torch [planned-sprint]	RESOLVED	WONTFIX
1033937	Paco Rampas [:paco]	[Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released	-	No cf_feature-b2g	[planned-sprint]	VERIFIED	FIXED
1039553	Doug Sherk (:drs) (inactive)	[Dialer][Call Screen] It's not possible to start a second call	---	No cf_feature-b2g	[planned-sprint]	RESOLVED	WORKSFORME

9 Total; 0 Open (0%); 5 Resolved (55.56%); 4 Verified (44.44%);

• Does not include Bugs Taken but not Completed.

Bugs Taken but not Completed

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Status	Resolution
1039643	Tamara Hills [:thills]	Write some unit tests for shared/js/dialer/contacts.js	---	No cf_feature-b2g	[planned-sprint c=][in-sprint=v2.1-S1]	RESOLVED	FIXED

1 Total; 0 Open (0%); 1 Resolved (100%); 0 Verified (0%);

Bugs Taken During Sprint

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature-b2g	Whiteboard	Status	Resolution
1021478	Doug Sherk (:drs) (inactive)	Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message	2.0M+	No cf_feature-b2g		RESOLVED	FIXED
1030623	Paco Rampas [:paco]	[Dialer] No space between text and border when Contact with long name and number matching hits	---	No cf_feature-b2g		VERIFIED	FIXED
1043318	Paco Rampas [:paco]	[Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen.	---	No cf_feature-b2g		RESOLVED	FIXED
1043904	Paco Rampas [:paco]	[Dialer][Call screen] There is a empty line at bottom of background image	---	No cf_feature-b2g		VERIFIED	FIXED
1047224	Paco Rampas [:paco]	[Dialer] [Keypad] Follow up for 1043318	---	No cf_feature-b2g		RESOLVED	FIXED

5 Total; 0 Open (0%); 3 Resolved (60%); 2 Verified (40%);

All Issues for this Sprint

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Whiteboard	Status	Resolution
967440	Anthony Ricaud (:rik)	Remove some reflows on the keypad	-	---	[priority][planned-sprint c=3][in-sprint=v2.0-S6]	RESOLVED	FIXED
995938	David Garcia [:davidg][retired]	Device does not play an 'end tone' when the call is finished	---	---	[priority][planned-sprint c=2]	VERIFIED	FIXED
998147	Tamara Hills [:thills]	[Dialer] A Missed Call notification is given when chosing to hang up on an incoming call	2.0+	---	[tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6]	VERIFIED	FIXED
1006592	Gabriele Svelto [:gsvelto]	While sending USSD code, last dialed number by user appears in dialer app	2.0+	---	[planned-sprint]	VERIFIED	FIXED
1010104	Germán Toro del Valle (:gtorodelvalle)	[Dialer][Call Screen] Baseline of the contact name when applying the fluid font size	---	---	[planned-sprint c=1][in-sprint=v2.0-S6]	RESOLVED	FIXED
1015883	Gabriele Svelto [:gsvelto]	[Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario	-	---	[planned-sprint c=3]	RESOLVED	FIXED
1021478	Doug Sherk (:drs) (inactive)	Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message	2.0M+	---		RESOLVED	FIXED
1023246	Paco Rampas [:paco]	[Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.	---	---	torch [planned-sprint]	RESOLVED	WONTFIX
1030623	Paco Rampas [:paco]	[Dialer] No space between text and border when Contact with long name and number matching hits	---	---		VERIFIED	FIXED
1033937	Paco Rampas [:paco]	[Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released	-	---	[planned-sprint]	VERIFIED	FIXED
1039553	Doug Sherk (:drs) (inactive)	[Dialer][Call Screen] It's not possible to start a second call	---	---	[planned-sprint]	RESOLVED	WORKSFORME
1043318	Paco Rampas [:paco]	[Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen.	---	---		RESOLVED	FIXED
1043904	Paco Rampas [:paco]	[Dialer][Call screen] There is a empty line at bottom of background image	---	---		VERIFIED	FIXED
1047224	Paco Rampas [:paco]	[Dialer] [Keypad] Follow up for 1043318	---	---		RESOLVED	FIXED

14 Total; 0 Open (0%); 8 Resolved (57.14%); 6 Verified (42.86%);

• Does not include Bugs Taken but not Completed.

Bugs Redirected

Full Query

ID	Assigned to	Summary	Blocking b2g	Feature b2g	Whiteboard	Status	Resolution
967440	Anthony Ricaud (:rik)	Remove some reflows on the keypad	-	---	[priority][planned-sprint c=3][in-sprint=v2.0-S6]	RESOLVED	FIXED
995938	David Garcia [:davidg][retired]	Device does not play an 'end tone' when the call is finished	---	---	[priority][planned-sprint c=2]	VERIFIED	FIXED
998147	Tamara Hills [:thills]	[Dialer] A Missed Call notification is given when chosing to hang up on an incoming call	2.0+	---	[tarako-bug-bash-1.3T][planned-sprint][in-sprint=v2.0-S6]	VERIFIED	FIXED
1006592	Gabriele Svelto [:gsvelto]	While sending USSD code, last dialed number by user appears in dialer app	2.0+	---	[planned-sprint]	VERIFIED	FIXED
1010104	Germán Toro del Valle (:gtorodelvalle)	[Dialer][Call Screen] Baseline of the contact name when applying the fluid font size	---	---	[planned-sprint c=1][in-sprint=v2.0-S6]	RESOLVED	FIXED
1015883	Gabriele Svelto [:gsvelto]	[Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario	-	---	[planned-sprint c=3]	RESOLVED	FIXED
1023246	Paco Rampas [:paco]	[Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.	---	---	torch [planned-sprint]	RESOLVED	WONTFIX
1033937	Paco Rampas [:paco]	[Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released	-	---	[planned-sprint]	VERIFIED	FIXED
1039553	Doug Sherk (:drs) (inactive)	[Dialer][Call Screen] It's not possible to start a second call	---	---	[planned-sprint]	RESOLVED	WORKSFORME

9 Total; 0 Open (0%); 5 Resolved (55.56%); 4 Verified (44.44%);

Daily Meetings

• Current hosts: drs, gtorodelvalle, thills
• Hosts rotate every week.

1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
2. Start by pinging everyone who should be participating.
3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
5. Move to individual updates. Go alphabetically, in descending order.
6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: August 4

drs

• On public holiday on Monday, will provide my update on Tuesday.
• Sprint planning will be on Tuesday.
• Please run the standup as usual on Monday. Anthony and I will not be there.
• I will host it in return for you hosting it on Friday :p Ups! It seems it's Tamara's turn :)

gtorodelvalle

• Administrative:
  • I spent most of today "welcoming" Jorge Prudencio, the new intern who will join us :) You know, installing the environment and so on. I will introduce him to you tomorrow hopefully.
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Patch ready.
  • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
  • I could not record the video due to a bug when establishing the second call: I will check with you during the meeting and if not know, I will create the bug.
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked for review from Anthony.
  • Rebased :-)
• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
  • Proposal made to Carrie and asked need-info to her regarding the final implementation.
  • Hopefully she agrees since we are following the proposed path ;)
  • Paco is working on the visual part.

pacorampas

• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • I'm working on some failures that German said me
• bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
• bug 1030623 -
  • It is waiting for 1043318 to land

thills

• bug 1039643 - Have a patch for review and waiting for that right now.
• bug 1026692 - Started looking at this and bug 1043133 depends on this so I'm looking at 1043133 right now.

// Part-time people (not required to update this)

Rik

• PTO

Day 9: August 1

Meeting Minutes

10:30 drs: hi gsvelto, Rik, thills 10:30 drs: welcome back from PTO, gsvelto 10:30 drs: gtorodelvalle can't make it today so he asked me to host 10:30 thills: Hello. Happy Friday 10:31 Rik: yo, still finishing my update :( 10:31 drs: ok, so let's get started, admin issues first: 10:31 drs: there was some crazyness in bug 1018283 between us and relman where a patch that could have easily landed and been fine didn't on 2.0 10:31 firebot: https://bugzil.la/1018283 — FIXED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen 10:32 drs: so we talked with them about it and I'm having a meeting with lmandel on tuesday to talk about things that they can do to improve, in particular what information we'd like to have from them 10:32 drs: Rik and I have compiled a list of the things we have thought of which you can find here: https://etherpad.mozilla.org/relman-information 10:32 drs: please please take a look and add anything you can think of. this will go a long way to improving the approval/landing process 10:33 drs: oh, also, monday is a public holiday in Canada 10:33 gsvelto: hi there 10:33 drs: I'm going to stick around for sprint planning, but I'll be gone after that 10:33 Rik: drs: could you invite me as optional to that meeting? 10:33 Rik: with relman 10:33 drs: Rik: sure, but it's an in-person meeting 10:33 drs: we could vidyo you in I guess 10:34 drs: ok, that's it for my admin updates 10:34 thills: drs: are you going to try that cdma suggestion? 10:34 drs: thills: no, I'm going to talk with Vance about it, I don't think he has the right idea 10:34 Rik: should we move our sprint planning to tuesday? 10:34 thills: I'm not sure they will do anything differently when I go tin the store with it 10:34 drs: thills: my thoughts exactly. let's talk about that after 10:34 drs: Rik: why? 10:34 Rik: I was planning to be on PTO on Monday 10:35 Rik: I can move it but if you are also on PTO, maybe we can move 10:35 drs: I'm wary of moving it during this standup in case others can't make it 10:35 drs: we don't know about paco or gtorodelvalle 10:35 drs: but I'll send out an email to the mailing list 10:35 drs: and if enough people are ok with it, we'll move it 10:35 drs: sound good? 10:35 Rik: ok let's do that 10:35 drs: ok, that's it for my admin updates 10:36 drs: my actual update: 10:36 drs: gsvelto: I need to talk with you about bug 991573 10:36 firebot: https://bugzil.la/991573 — ASSIGNED, david.garciaparedes — Copy improvements in Call Barring service through MMI 10:36 drs: but we can talk after this 10:36 gsvelto: drs, sure 10:36 drs: that's it for me. next is Rik 10:37 Rik: I've split the call duration bug and the good news is that we'll be able to put several people on it next sprint 10:38 Rik: also, I'll be on PTO monday or wednesday, depending on the sprint planning 10:38 Rik: that's it for me 10:38 drs: (monday is Rik's birthday, make sure you wish him a good one) 10:38 drs: next is gsvelto 10:39 gsvelto: drs, still waiting for ux review 10:39 gsvelto: in bug 1015883 10:39 firebot: https://bugzil.la/1015883 — ASSIGNED, gsvelto — [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario 10:39 gsvelto: which is otherwise ready to land 10:39 gsvelto: and that's it for now 10:40 drs: gsvelto: do you have work to do? 10:40 gsvelto: drs, a lot :) 10:40 gsvelto: drs, k 10:40 drs: gsvelto: heh, ok 10:40 gsvelto: gecko stuff 10:40 gsvelto: + sms app profiling 10:40 gsvelto: and wap push stuff 10:40 drs: ok, thanks. next is thills 10:40 gsvelto: sorry I'm typing with only one hand 10:40 drs: haha 10:40 gsvelto: holding the baby with the other 10:40 Rik: gsvelto: TMI! :) 10:41 drs: "baby" 10:41 thills: I have a pull request for bug 1039643 and waiting for review on this one. I started looking around for sth else to work on. 10:41 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js 10:41 drs: Rik, thills: maybe we could assign one of the broken up pieces of bug 877984 to thills? 10:42 firebot: https://bugzil.la/877984 — FIXED, fabrice — [Buri] Trying to update a hosted app preloading appcache that was preinstalled will fail to update 10:42 drs: sorry, wrong bug number. bug 877971 10:42 firebot: https://bugzil.la/877971 — NEW, anthony — The call logs menu doesn't show the call time duration 10:42 Rik: I was going to look at our feature work but sure 10:43 drs: ok, we can talk about that after 10:43 drs: anything else? 10:43 thills: not from me 10:43 drs: thanks everyone, meeting over

drs

• Admin:
  • I'm meeting with Lawrence (:lmandel) on Tuesday to talk about information that relman can provide us with to help us. Anthony and I have been compiling a list for this, please add to it if you have anything: https://etherpad.mozilla.org/relman-information
  • Went back to talk with Vance about CDMA in NA.
• Next steps:
  • bug 1047224 - [Dialer] [Keypad] Follow up for 1043318
    • Need to review this for Paco.
  • bug 991573 - Copy improvements in Call Barring service through MMI
    • I need to talk with Gabriele about this.
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Investigated this, I think we're going to have to do a Gaia-side workaround and not use touch listeners, or manually set the "active" state on the keypad.
  • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
    • Put up a patch, but we're going to change bug 1037868, so this will need a bit more work first before it goes into review.
  • bug 982163 - Remove SimSettingsHelper.getCardIndexFrom shim in CallHandler.call()
    • Going to check if we can remove this.
• Done:
  • bug 1037868 - Create gaia-sim-picker component
    • Put up for review, going to make a couple of changes and come back.
  • Quick review of https://github.com/mozilla-b2g/gaia/commit/f3f3a79dbce08865b1bf2c4c3fcfbfa59c9a2f1f for Kevin

Rik

• Will move my PTO from Monday to Wednesday so I can be in sprint plannings
• Landed bug 967440 \o/
• Feedback for thills bug 1039643
• Overruled review on bug 1032282
• We can split the call duration work in UI/DB work. See https://bugzilla.mozilla.org/showdependencytree.cgi?id=877971&hide_resolved=1
• Studying http://dev.opera.com/articles/introduction-to-indexeddb/ because I'm still uncomfortable manipulating the call log db
• Going over Call log db. Looks like we can ditch one store recentsStore because it is not used.

gtorodelvalle

• Administrative:
  • Sadly I won't be able to join me to the meeting so it would be great, Doug, if you could host it :) Thanks!
    • <drs> Will do! Thanks for letting me know.
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Patch ready.
  • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked for review from Anthony.
• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
  • Proposal made to Carrie and asked need-info to her regarding the final implementation.
  • Hopefully she agrees since we are following the proposed path ;)

pacorampas

• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • I'm working on some failures that German said me
• bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
• bug 1030623 -
  • It is waiting for 1043318 to land
• bug 1047224 - [Dialer] [Keypad] Follow up for 1043318

thills

• bug 1039643 - Have a patch for review and waiting for that right now.

Day 8: July 31

Meeting Minutes

[4:31pm] gtorodelvalle: Hi drs Rik thills ! Time for our daily meeting [4:31pm] drs: hello [4:31pm] thills: hello [4:31pm] gtorodelvalle: I think Rik is no longer updating the Etherpad so let’s start Any administrative issue? [4:32pm] gtorodelvalle: Ups, he is [4:32pm] Rik: no we can go [4:32pm] drs: yes, so unfortunately we couldn't land bug 1018283 on 2.0 [4:32pm] firebot: https://bugzil.la/1018283 — FIXED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen [4:33pm] drs: Rik and I argued to land it for a while, and we still disagree with relman's decision, but we did everything we realistically could [4:33pm] drs: I'm going to be meeting with lmandel to talk about this and what they could do better [4:33pm] gtorodelvalle: Yeap, I’m sad I missed that single locale string If i didn’t it would have landed [4:33pm] drs: so if you have any information you'd like from relman, please let me know so I can get it all in one spot [4:33pm] drs: yeah, we're really sorry about this gtorodelvalle, we know you worked hard on it [4:33pm] gtorodelvalle: [4:33pm] drs: but at least it landed on master [4:34pm] drs: anyways that's it for my admin updates [4:34pm] gtorodelvalle: Yeap, and we will improve the process [4:34pm] gtorodelvalle: So, time for individual reports drs ? [4:34pm] drs: ok [4:34pm] drs: I need to talk with gsvelto, who isn't here right now, about bug 991573 [4:34pm] firebot: https://bugzil.la/991573 — NEW, david.garciaparedes — Copy improvements in Call Barring service through MMI [4:35pm] drs: oh also one other note from Rik that he left in my report, if you get 1.4+ blocking, you still need to explicitly request permission to land on 2.0 [4:35pm] drs: that's all for me [4:35pm] gtorodelvalle: Thanks! I do not know why Rik appears below today so I’ll go next [4:35pm] drs: oh and I'd like to land bug 967440 today so I'll be reviewing that first thing after this [4:35pm] firebot: https://bugzil.la/967440 — ASSIGNED, anthony — Remove some reflows on the keypad [4:36pm] gtorodelvalle: In fact, nothing to report on my side apart from what’s included in the Etherpad [4:36pm] Rik: (RyanVM who does the uplifts will tell you about asking for 2.0 uplifts so no need to remember) [4:36pm] gtorodelvalle: That’s my style [4:36pm] gtorodelvalle: Next is Rik [4:37pm] Rik: I'm slacking on reviews on purpose to get some feature work done [4:37pm] gtorodelvalle: He, he… [4:37pm] Rik: I'll still look at them later today but that's why [4:37pm] gtorodelvalle: Thanks! [4:38pm] Rik: if you think one is more important, tell me [4:38pm] drs: Rik: sorry to sprinkle something from me into your talk, I forgot to mention not to bother reviewing bug 1037868 yet because I want to address kgrandon's comments first to save you time [4:38pm] Rik: that's it for me [4:38pm] firebot: https://bugzil.la/1037868 — ASSIGNED, drs+bugzilla — Create gaia-sim-picker component [4:38pm] gtorodelvalle: Next is thills [4:38pm] thills: Still working on bug 1039643 and taking help from rik on this. Created a workaround for the issue that I ran into with an existing mock. Have a new WIP feedback posted. That's it from my side. [4:39pm] firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js [4:39pm] gtorodelvalle: Thanks! [4:39pm] gtorodelvalle: Does anyone want to add anything else? [4:39pm] Rik: yup [4:39pm] Rik: gtorodelvalle: about bug 889737, why would we take it in the next sprint? [4:39pm] firebot: https://bugzil.la/889737 — NEW, szchen — [MMI] Unify both sendMMI() and dial() functions [4:40pm] gtorodelvalle: Rik: I have been asked to try to deal with the Gaia side but sincerelly until there is not Gecko counterpart or concrete decisions about it I do not think it makes much sense [4:41pm] Rik: exactly [4:41pm] gtorodelvalle: Maybe just to know what should be updated to make it work ASAP [4:41pm] Rik: the RIL team is gonna work on it in sprint 3 [4:41pm] Rik: (at best) [4:41pm] Rik: and this is not a 2.1 feature [4:41pm] gtorodelvalle: In fact, I was asked to start working on it now and I suggested to discuss about it in our next spring planning [4:41pm] drs: gtorodelvalle: who asked you to start working on it now? [4:41pm] gtorodelvalle: So I think we can decide about it there [4:42pm] gtorodelvalle: mariaoteo and Antonio Amaya [4:42pm] drs: ok [4:42pm] Rik: well, there's not much to decide. you can't work on it because there's not even a work in progress gecko patch [4:42pm] drs: mariaoteo: please see above. just an FYI that we can't work on bug 889737 because it requires gecko work first [4:43pm] Rik: gtorodelvalle: Amaya, like the browser? [4:43pm] gtorodelvalle: Yeah, I think what we want is to have the Gaia part under control (meaning where we shoud include changes) but definitely this will finally be affected by the Gecko final implementation [4:44pm] gtorodelvalle: Like a gipsy group here in Spain [4:44pm] gtorodelvalle: Cultural note: https://www.youtube.com/watch?v=GaHjCPRH0Nc&list=PLCEE3C5F02C56D979 [4:44pm] drs: without the gecko part, we can't test if the gaia part is working. I guess we could write unit tests, but it seems unnecessary because it shouldn't be very costly to just do it once the gecko part is ready [4:45pm] drs: but I think Rik would know more about this than me [4:45pm] gtorodelvalle: I agree I will share this with them [4:45pm] drs: ok, thanks [4:45pm] drs: if you really want to I think it's possible to get started on it, I just recommend against it [4:45pm] drs: when the time comes, we'll make sure you have the cycles to work on it [4:45pm] gtorodelvalle: Yeah, I agree [4:46pm] drs: (or someone does) [4:46pm] Rik: gtorodelvalle: the API is not settled at all, nor the transition plan [4:46pm] gtorodelvalle: Yeah, yeah, that was my feeling after reading all the comments [4:46pm] Rik: gtorodelvalle: I've proposed a transition plan where we don't have to do much but that was before we thought about the new API [4:47pm] gtorodelvalle: I definitely agree with you and I guess they will also do it when I share this information with them tomorrow [4:47pm] Rik: so I'm not sure that Gecko can still do the compatibility part [4:47pm] Rik: ok cool [4:47pm] gtorodelvalle: Just wanted to know your thoughts about it and they are cristal clear [4:48pm] gtorodelvalle: So thank you very much, I guess the meeting is over You’re ruinig my hosting timing stats [4:48pm] Rik: I've dealt with the previous API change (promises for dial()) and it was pretty easy to do but only once we got the first Gecko WIP [4:48pm] gtorodelvalle: [4:48pm] Rik: nah, I'm sure drs stopped the clock earlier [4:48pm] gtorodelvalle: [4:48pm] drs: heh [4:48pm] drs: we're 8 minutes over our target! [4:49pm] mariaoteo: drs: Thanks Dough, I know [4:49pm] gtorodelvalle: Damn it!!! [4:50pm] mariaoteo: drs: we are aligning with Gecko team [4:50pm] drs: mariaoteo: once they get their part done, we'll make sure someone works on the gaia part [4:51pm] Rik: drs: well, this is not a 2.1 feature so I wouldn't promise this either [4:52pm] drs: Rik: well, at the very least, gtorodelvalle can work on it [4:52pm] mariaoteo: drs: thanks Dough, Hsin-Yi set the target milestone for 889737 as 2.1 S3 (20aug) [4:53pm] Rik: we have it on our radar, I'm just saying that in terms of priority, it is still under other 2.1 features [4:53pm] mariaoteo: drs: I hope German can work on Gaia side in parallel [4:54pm] mariaoteo: Rik: sure, I understand [4:54pm] drs: mariaoteo: once the API is stabilized, it will make more sense to work on it, but it makes the most sense to get started once the gecko part is actually landed [4:55pm] mariaoteo: yep, I understand all you said, but we are working on the Gaia part because wilfredm requested us to try to land this for 2.1 as Mozilla did not have resources to make it happen [4:56pm] mariaoteo: in other words, it's still a priority for 2.1 and the only change is that Gaia part will be done by TEF engineers [4:56pm] drs: ok, I understand. if the gecko part actually lands in S3 I don't think there will be a problem here [4:56pm] mariaoteo: the plan has been discussed in detail with wilfredm, ask him for more details about that if you have any doubt

drs

• Admin:
  • bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
    • What happened with this bug was really unfortunate. You can read comment 76 for a summary. I'm meeting with Lawrence on Tuesday to talk about what we can do to prevent this from happening again in the future. I'm going to provide him with all the info that we'd like to have on the regular from relman.
    • <Rik> Not entirely related but https://bugzilla.mozilla.org/show_bug.cgi?id=1021478#c50 is really helpful notice
• Next steps:
  • bug 991573 - Copy improvements in Call Barring service through MMI
    • Review- for David, I need to talk with Gabriele about this.
  • bug 1037868 - Create gaia-sim-picker component
    • Review- from Kevin. Also needs review from Anthony.
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Going to work on this today.
  • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
    • This has turned into a port of every app, so it's taking a bit longer than I wanted it to.
• Done:
  • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • Landed on master, then got 1.4+ status, so now I have to uplift it.

Rik

• Helped thills with the tests
• New version of bug 967440, reflows
• Argued for uplift of bug 1018283
• Reviews
  • bug 1043318 gotta take another look though since Daniel is recommending using max-width
  • bug 1015883

// Better for wiki

• Looked into how to split the call duration work bug 877971, will open bugs later:
  • Insert duration in call log DB
  • Create new page (could be split in several steps too)
  • Link page to main call log

gtorodelvalle

• Administrative:
  • Nothing to report.
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Patch ready.
  • ui-review+ by Carrie. I will record a new video tomorrow showing the suggested conference call duration. This is already included in the patch to be reviewed.
• bug 889737 - [MMI] Unify both sendMMI() and dial() functions:
  • I have been familiarising with this bug since I have been kindly asked to include it in our next sprint.
  • The approach seems to be the one suggested by Anthony at https://bugzilla.mozilla.org/show_bug.cgi?id=1031193#c1
  • <Rik> How can we include in the next sprint since the Gecko work is not done?
  • Yeap, does not make much sense to me either :)
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked for review from Anthony.
• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold:
  • Helping Paco to try to get a working patch ASAP :)

thills

• bug 1039643 - Took help from Rik yesterday on this. Created a workaround for the issues I ran into trying to reuse the mock_fb object. Posted the latest patch for feedback from Rik.

// Part-time people (not required to update this)

pacorampas

• Absent/no report

Day 7: July 30

Meeting Minutes

[4:30pm] gtorodelvalle: Hi guys drs Rik gsvelto and thills [4:30pm] drs: hello [4:30pm] thills: hello [4:30pm] gsvelto: hi everybody [4:30pm] gtorodelvalle: Hey! That was fast [4:30pm] gtorodelvalle: I think drs has some administrative issue to share? [4:31pm] drs: yes, bug 1029142 looks pretty serious and I expect that we'll be pressured into fixing it, probably by it getting set as a blocker [4:31pm] firebot: https://bugzil.la/1029142 — NEW — Call log deletions don't persist after killing the app [4:31pm] drs: I think we should take it if anyone has bandwidth, but if not, then we can take it next sprint [4:31pm] drs: if nobody takes it after the meeting, I'll just put it in next sprint [4:31pm] drs: that's it for me [4:31pm] gtorodelvalle: Thanks! Any other issue? [4:31pm] drs: (for admin at least) [4:31pm] Rik: I'll take a quick look to see if it could be a regression of bug 1029581 [4:32pm] firebot: https://bugzil.la/1029581 — FIXED, anthony — [Dialer] Contact name is not shown in the call log after having two contacts with same number and th [4:32pm] drs: Rik: it's not a regression, it has always existed [4:32pm] Rik: oh [4:32pm] Rik: let's wait for the next sprint then [4:32pm] drs: ok I'll go into my update [4:32pm] gtorodelvalle: So, moving to individual reports… drs ? [4:32pm] gtorodelvalle: yeap [4:33pm] drs: I've been working on bug 1037868 which is a pretty massive port of the SimPicker code into a web component [4:33pm] firebot: https://bugzil.la/1037868 — ASSIGNED, drs+bugzilla — Create gaia-sim-picker component [4:33pm] drs: ordinarily I wouldn't mention this but it's getting close to being done, so I thought others would want to know to watch out for regressions in the SIM picker once this lands [4:33pm] drs: that's it for me [4:33pm] gtorodelvalle: Rik ? [4:34pm] Rik: I emailed release management for bug 1018283 so that we can have a response pretty soon [4:34pm] firebot: https://bugzil.la/1018283 — FIXED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen [4:34pm] drs: yeah, you will still have to wait at least 2 hours [4:35pm] drs: I guess Rik and I can deal with that when the answer comes [4:35pm] Rik: I'm also worried about my 2.1 feature work because I have many tasks that prevent from getting to it [4:35pm] Rik: that's it for me [4:35pm] drs: we can chat about that after? [4:36pm] • drs pokes gtorodelvalle [4:36pm] Rik: next? [4:36pm] drs: gsvelto [4:36pm] gtorodelvalle: Oh, I though you meant Rik [4:36pm] gtorodelvalle: Sure! [4:36pm] gtorodelvalle: Next is gsvelto [4:36pm] gsvelto: So I'm pretty much done with bug 1015883, I'll just be waiting for the ux-review before landing [4:36pm] firebot: https://bugzil.la/1015883 — ASSIGNED, gsvelto — [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario [4:36pm] drs: (yeah, I meant Rik and I should chat about his 2.1 features after) [4:37pm] gsvelto: And that's it for now, I may have a look at the bug drs mentioned before since I've basically cleared all bugs I picked in my sprint [4:37pm] gsvelto: Though I'm also doing some Gecko work in parallel [4:38pm] drs: gtorodelvalle [4:38pm] gtorodelvalle: Done? (this needs a “typing” notification as hell…) [4:38pm] gtorodelvalle: On my side just thanking Doug for preparing yesterday’s minutes and telling Anthony I’ll ask a review from him regarding bug 1024506 in a sec. [4:38pm] firebot: https://bugzil.la/1024506 — NEW, gtorodelvalle — While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled. [4:38pm] gtorodelvalle: The rest in on the Etherpad [4:38pm] gtorodelvalle: Next is thills [4:38pm] thills: I'm still working on bug 1039643 and taking help from Rik where I'm stuck with the fb library mocks. That's it from my side. [4:38pm] firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js [4:38pm] gtorodelvalle: So, I think this is it Thank you guys! [4:39pm] drs: thanks [4:39pm] drs: gtorodelvalle: I've found it's best to ask if anyone has anything they want to talk about at the end, because sometimes they do [4:39pm] gtorodelvalle: He, he… Yeah, sorry about that Does anyone want to add anything? My nap awaits (kidding) [4:40pm] drs: heh, I think you can go have your nap [4:40pm] gtorodelvalle: \o/

drs

• Admin:
  • bug 1029142 - Call log deletions don't persist after killing the app
    • I think this will become a blocker. If anyone has bandwidth, we should take it. If not, we can take it next sprint.
• Next steps:
  • bug 991573 - Copy improvements in Call Barring service through MMI
    • Need to review this for David.
  • bug 1037868 - Create gaia-sim-picker component
    • I put this up and got feedback+ from Kevin. I need to move over the unit tests, and then we'll be good to go into real review for this.
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Going to work on this today.
  • bug 1045820 - Port dialer's SimPicker implementation to GaiaSimPicker
    • I have a WIP, going to try to finish this today.
• Done:
  • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • Posted another revision, got review+ from Anthony, need to land it.

Rik

• Still hasn't started on call duration work, too many interruptions yesterday and today :(
• Discussed bug 959011 with Julien
• Helped Carrie run the prototype
• Helped thills with tests
• Emailed release management to get bug 1018283 to land
• bug 1038714 is no longer a 2.1 feature nor something we want to fix
• Tried to reproduce bug 1039610, no idea why it's working now
• I'm not sure yet if bug 1043318 is a Gaia or Gecko bug so asked help
• Thinking about 2.2, I'd like to split Dialer and Contacts so we need some investigation first, opened bug 1046090 for that and put that in the next sprint.
• Reviews
  • bug 1021478
  • bug 1015883
  • bug 1042586

gtorodelvalle

• Administrative:
  • <drs> I put the meeting notes and minutes for today on the wiki. Please try to remember next time. I think you were in a hurry and had a lot to do, so it's ok.
  • Yeah, I copied them before leaving to do it later and when I was about to do it yesterday night I noticed you had already done it, so thank you ;)
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Patch ready.
  • Demo at http://youtu.be/iF1K2DovRV8 I will include it on our Demo section once some issues I asked Carrie about the time to be shown are clarified.
  • Asked for revision from Anthony until Carol and Carrie reply to my ui-review request.
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked for review from Anthony.
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
  • <drs> We need to figure out what to do with this now that it was backed out of 2.0. I've had a lot of experience with the problem you're facing now. Let's chat tomorrow (Tuesday).
  • New patch included applying Doug's suggestion.
  • Asked for approval for v2.0 as agreed with Anthony.
• bug 967440 - Remove some reflows on the keypad:
  • Provided feedback to Anthony as requested.
• bug 1030811 - CallScreen app debugging not working:
  • Provided feedback to Paul Rouget about the issue.

pacorampas

• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • Working on visual part
  • Added the on hold button
  • I started with the logic
  • Splitted in two bugs
• bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
• bug 1030623 -
  • It is waiting for 1043318 to land

thills

• bug 1039643 - Still working on this and taking some help from Anthony where I am stuck.

// Part-time people (not required to update this)

Day 6: July 29

Meeting Minutes

10:30 gtorodelvalle: Hi guys drs Rik gsvelto thills :) Time for the meeting 10:30 drs: hi gtorodelvalle 10:30 gsvelto: hi there 10:31 gtorodelvalle: Any administrative issues? 10:31 drs: yes 10:31 drs: I have two 10:31 drs: for starters, I've noticed that people haven't been making demos for their bugs 10:31 drs: I think gtorodelvalle is the first to do so, and it was today 10:31 gtorodelvalle: :) 10:32 drs: so if you've been doing any feature work or anything the end user would see, please go back and make a demo of it 10:32 gsvelto: I might be able to do one too 10:32 drs: you can add them here: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.1-S1#Demos 10:32 drs: here's an example: https://wiki.mozilla.org/Gaia/SMS/Scrum/2.0S6#Demos 10:32 gtorodelvalle: I will check tomorrow with Paco since the bug he is working on will have a demo ;) 10:32 drs: yeah, thanks 10:32 drs: my other admin issue is that I'm concerned with our progress so far in the sprint 10:32 drs: I think we will finish everything assigned to us, but thankfully we didn't have any blockers come up 10:33 drs: I think if we hadn't gotten lucky, we would probably be overloaded right now 10:33 drs: we did say when we started that we might have to unassign things, so this is ok 10:33 drs: and this is a good chance to improve our estimating 10:33 drs: anyways that's it for my admin 10:34 gtorodelvalle: Thanks drs ;) I think we can continue with your update if any :) 10:34 drs: sure, the only thing I have to draw attention to is bug 1018283 which gtorodelvalle and I should talk about afterwards 10:34 firebot: https://bugzil.la/1018283 — FIXED, gtorodelvalle — [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen 10:34 gtorodelvalle: Yeap ;) 10:34 drs: that's it for me, the rest of my updates are on etherpad and I don't think require attention 10:34 drs: Rik 10:35 Rik: I have to finish my needinfos/reviews before tackling on my feature work 10:36 Rik: I will probably redirect some to drs but I haven't looked at them so I don't know which yet 10:36 drs: Rik: do you think we should do any offloading? my main bug right now, bug 1037868 is relatively unimportant 10:36 firebot: https://bugzil.la/1037868 — ASSIGNED, drs+bugzilla — Create gaia-sim-picker component 10:36 drs: heh, read my mind 10:36 Rik: that's it for me 10:37 drs: next is gsvelto 10:37 drs: pokes gtorodelvalle 10:37 gsvelto: I've been working on bug 1015883 10:37 firebot: https://bugzil.la/1015883 — NEW, gsvelto — [Dialer][Call Screen][Call Waiting] Apply the visual refresh to the CDMA call waiting scenario 10:37 gsvelto: It's almost done and I've been able to simplify the DOM & CSS code involved quite a bit 10:38 gsvelto: mostly thanks to the new design, but that's good, it will be more robust from now on 10:38 gsvelto: I'll make a demo because the change is visible 10:38 gsvelto: And this is all for me 10:38 drs: thanks, next is gtorodelvalle but I think he's afk, so let's go to thills 10:38 gtorodelvalle: On my side and as mentioned by drs , I have a patch and demo for the showing of the call duration when the participant list overlay is shown. It was kind of tough due to the moving of (call) nodes we currently do :) On the other hand, sorry for not noticing that there was a locale string updated in bug 1018283 :O 10:38 drs: or not 10:38 gtorodelvalle: He, he 10:39 gtorodelvalle: Next is thills 10:39 thills: so, I took some feedback from rik on the unit tests and am working on incorporating this. 10:39 thills: that's it from my side 10:39 gtorodelvalle: Thank you guys! The meeting is over :) 10:39 thills: sorry… bug 1039643 10:39 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js

drs

• Admin:
  • Not enough demos.
  • Concerned about schedule/progress so far.
• Next steps:
  • bug 1037868 - Create gaia-sim-picker component
    • I put up an example case for Kevin and he found the problem in my code, so I'm going to continue on this.
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Will work on this if I have time.
• Done:
  • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • I put up a second revision of my patch for Anthony to review.
  • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
    • Review- again for David.
  • bug 967440 - Remove some reflows on the keypad
    • Review- for Anthony. This is a great patch but it's so big that it was bound to have problems.

Rik

• Finally put bug 967440 in review
• Requesting other designs for bug 977588 and bug 945225. I think those designs will modify the cases already designed
• Discussed contacts form animation with Francisco
• Redirected https://wiki.mozilla.org/FirefoxOS/Dialer/Call_screen_states
  • <drs> FYI, it's preferred practice for wiki articles to not use underscores, so here it would be best to use "Call Screen States", but this is a redirect so it doesn't matter.
• Did some reviews
  • bug 1021478
  • bug 1039643
  • bug 1043318
  • bug 1043904
• Tried to help get bug 1018283 unstuck
• Massaged bug 1045499 to get it action ready for next sprints
• Helped thills with tests on bug 1039643

gtorodelvalle

• Administrative:
  • Nothing to report
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Patch ready.
  • Demo at http://youtu.be/iF1K2DovRV8 I will include it on our Demo section once some issues I asked Carrie about the time to be shown are clarified.
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked review from Anthony.
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen
  • <drs> We need to figure out what to do with this now that it was backed out of 2.0. I've had a lot of experience with the problem you're facing now. Let's chat tomorrow (Tuesday).
  • Wow! I was (wrongly) sure that no strings were modified. Next time I will check it no matter how sure I am :(
  • <drs> It happens. There's a saying that if you never miss a flight, you're spending too long at the airport. But if you're missing many, you're not getting there early enough.

pacorampas

• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • Working on visual part
  • Added the on hold button
  • I started with the logic
  • Splitted in two bags
• bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
  • we are testing differents hits sate
• bug 1043318 - [Dialer] [Keypad] On suggestion item when the text goes outside the edge, you can drag the upper part and move the whole screen.
  • I have asked Rik to improve the code of suggestion. (As a comment on this bug)
  • It is ready to land. When this bug will land, the 1030623 bug will land also

thills

• bug 1039643 - I took some feedback from Rik on this and am re-working things a bit to focus more towards the output validation than validation of function calls via spies.

Day 5: July 28

Meeting Minutes

[4:30pm] gtorodelvalle: Hi guys! Ready for today’s meeting? [4:30pm] drs: hi gtorodelvalle [4:30pm] gtorodelvalle: drs Rik etienne_s gsvelto thills davidg [4:30pm] thills: hello [4:31pm] gtorodelvalle: Any administrative issue to share? [4:31pm] drs: not on my side [4:31pm] thills: not from me [4:31pm] Rik: nope [4:31pm] gtorodelvalle: OK, so moving on [4:31pm] davidg: hi [4:31pm] gtorodelvalle: drs ? [4:31pm] drs: I have nothing to specifically draw attention to [4:32pm] drs: next is Rik [4:32pm] Rik: I'm very close to submit my patch for the reflow bug [4:32pm] Rik: so I can go back to 2.1 feature work [4:32pm] Rik: and that's it [4:33pm] gtorodelvalle: Next is etienne_s ? [4:33pm] gtorodelvalle: Or maybe not [4:33pm] Rik: not [4:33pm] gtorodelvalle: Next is davidg [4:33pm] drs: I don't think etienne_s is generally participating in these anymore [4:33pm] gtorodelvalle: OK [4:33pm] davidg: we landed bug 995938 [4:33pm] firebot: https://bugzil.la/995938 — FIXED, david.garciaparedes — Device does not play an 'end tone' when the call is finished [4:34pm] davidg: I made changes for 911055 to fix the things drs commented [4:34pm] davidg: bug 911055 [4:34pm] firebot: https://bugzil.la/911055 — NEW, david.garciaparedes — [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>> [4:34pm] davidg: and now working on bug 8413668 [4:34pm] davidg: thats it next [4:34pm] gtorodelvalle: Is gsvelto [4:35pm] gtorodelvalle: Maybe attending his kid [4:35pm] gtorodelvalle: So I’ll go next [4:35pm] davidg: sorry was bug https://bugzilla.mozilla.org/show_bug.cgi?id=849729 [4:35pm] firebot: Bug 849729 — NEW, david.garciaparedes — To support vCard 2.1 (mime-type: text/x-vCard) [4:35pm] gtorodelvalle: Nothing important on my side. Working on the conference call duration feature and trying to find why a call is magically removed from the list as mentioned in the Etherpad [4:35pm] gtorodelvalle: Nex is thills [4:36pm] thills: I'm still working on tests for bug 1039643. I have a bit more to go to have it in a draft form (e.g. all the functions covered). Then need to clean up a bit [4:36pm] firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js [4:36pm] thills: that's it from my side [4:36pm] drs: nice and fast. I guess gsvelto isn't around [4:36pm] gtorodelvalle: Great! Thank you everyone! I’ll update the minutes in a sec. [4:37pm] drs: thanks gtorodelvalle [4:45pm] gsvelto: drs, sorry, here I am [4:45pm] gsvelto: drs, not much to report anyway

drs

• Admin:
  • Nothing new.
• Next steps:
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Next bug to work on, and my last assigned for this sprint. I have a WIP patch posted already.
    • <Rik> I thought the patch was just to showcase an APZC bug. Do you think it will be a Gaia fix?
    • It's not a bug with APZC I don't think, just a limitation. Even if it's an APZC bug, it'll be a lot faster to fix in Gaia for now. I'll check with kats and Botond though.
  • bug 1037868 - Create gaia-sim-picker component
    •  :kgrandon wants a reduced test case for a potential platform problem I'm facing.
• Done:
  • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
    • Resolved WFM.
  • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • I put up a patch for Anthony to review.
  • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
    • Review- for David. This will probably need some new unit tests.

Rik

• Moved my dogfooding phone to Flame.
• bug 967440 is ready-ish. I'm checking that the tests pass, testing on the device again before submitting it
• Will work on bug 877971 after my needinfos/feedbacks are done.

gtorodelvalle

• Administrative:
  • Nothing to report
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Retook this bug.
  • Filed a new one I found (see next).
  • Have a working patch.
  • Trying to find out why if there is a conference call among 3 parties, if 1 of them leaves the conference when the participant list overlay is shown, the other one is "magically" removed from the list.
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • ui-review+ by Carol.
  • Asked review from Anthony.

thills

• bug 1039643 - Working on this still. Put a version for feedback to make sure I'm going in right direction with this.

// Part-time people (not required to update this)

pacorampas

• Absent/no report

Day 4: July 25

Meeting Minutes

10:30 drs: hi all, looks like it's that time again 10:30 drs: Rik, davidg, gsvelto, gtorodelvalle, thills 10:30 thills: here 10:30 gtorodelvalle: Hey! 10:30 drs: hey, ok, let's get started 10:30 Rik: hi hi 10:31 drs: admin updates: thills and I have been trying to get our wasabis working on CDMA in NA, so far no luck, but I emailed wesley and he's been helping us out 10:31 drs: that's all for my admin updates. anyone else have anything? 10:31 gtorodelvalle: Nope, on my side 10:31 drs: ok, moving onto my actual update 10:31 drs: I can't repro bug 1039553 10:32 firebot: https://bugzil.la/1039553 — NEW, drs+bugzilla — [Dialer][Call Screen] It's not possible to start a second call 10:32 drs: gtorodelvalle: I thought you might know about this, we can talk about it after 10:32 drs: that's it for me. next is Rik 10:32 Rik: still in my reflow bug 10:32 Rik: I am a bit disappointed by the unit testing state for FontSizeManager 10:32 Rik: a lot of cases are not tested 10:33 drs: yes, that's my fault, I should have requested more tests in review 10:33 drs: we'll be filing followup bugs and fixing that 10:33 Rik: I will write those tests but let me remind you that because we don't have automated integration tests, the state of our unit tests is crucial 10:33 gsvelto: here I am, sorry for being late 10:33 Rik: that's it for me 10:34 drs: ok, next is davidg 10:34 scravag has joined (Thunderbir@DA4ABEAF.1DE10CA8.D8E68FF6.IP) 10:34 davidg: Hi, on bug 976678, I fixed the problems that were interfering with Voip/Loop and added some tests. so it is ready for review 10:34 firebot: https://bugzil.la/976678 — UNCONFIRMED, david.garciaparedes — [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep. 10:34 drs: davidg: I forgot to mention, I looked at bug 911055 and it looks good, I'll be doing actual review for it today 10:34 firebot: https://bugzil.la/911055 — NEW, david.garciaparedes — [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>> 10:34 davidg: About bug 995938 Carrie said ok so its ready for final review 10:34 firebot: https://bugzil.la/995938 — NEW, david.garciaparedes — Device does not play an 'end tone' when the call is finished 10:35 davidg: thanks drs: 10:35 drs: davidg: ok, can you request review from someone for bug 976678? 10:35 davidg: drs: etienne is on review for that one 10:35 drs: ok, thanks. is that everything for your update? 10:35 davidg: also i have bug 991573 for review too 10:36 firebot: https://bugzil.la/991573 — NEW, david.garciaparedes — Copy improvements in Call Barring service through MMI 10:36 davidg: yes thats all 10:36 davidg: thanks :) 10:36 drs: ok, next is gsvelto 10:36 drs: (davidg: man, you're a machine) 10:36 gsvelto: not much to report 10:37 gsvelto: I've been busy helping out the SMS team on a signifcant performance regression they hit so I haven't had much time for the dialer, sorry :( 10:37 davidg: davidg: XD each of those ones is like 4 lines of code. So 16 lines total 10:37 gsvelto: though I did a brief investigation of bug 1043817 fearing it was a regression from my recent USSD changes 10:37 drs: gsvelto: ok, thanks. next is gtorodelvalle 10:37 firebot: https://bugzil.la/1043817 — NEW — [OPEN_C][v2.0]USSD Session Expired 10:37 drs: (sorry, thought you were done) 10:37 gsvelto: it turns out it doesn't seem to be one 10:37 gsvelto: now I'm done :9 10:37 gsvelto: :) 10:37 gtorodelvalle: Nothing important to report on my side either. Just mentioning that I’ll contact Carrie to validate some edge cases I found related to bug 977056 :) 10:37 firebot: https://bugzil.la/977056 — NEW, gtorodelvalle — [Dialer] Visual discrepancies: Call ended view under conference call participants list 10:38 gtorodelvalle: Next is thills 10:38 thills: I'm still working on bug 1039643. 10:38 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js 10:38 thills: I'm hoping for ready for feedback on monday 10:38 thills: that's it from my side 10:38 drs: ok, anything else anyone wants to talk about? 10:39 thills: oh… one more admin thing… 10:39 drs: ok 10:39 thills: drs: I forgot to mention that I checked with Verizon online... 10:39 thills: and they have the same thing as sprint… you enter IMEI/MEID... 10:39 thills: and it says it won't work 10:39 drs: yeah, not surprised. we'll see how our talks with the taiwan people go 10:39 thills: I feel like we'd need someone to approach the carrier here 10:40 drs: maybe 10:40 drs: ok, thanks everyone, meeting over

drs

• Admin:
  • Tamara and I couldn't get our Wasabi devices connected to NA carriers, so I emailed Wesley to ask for help based on the information that the carriers provided.
• Next steps:
  • bug 1037066 - [Dialer] Keypad background color changes are delayed
    • Next bug to work on, and my last assigned for this sprint. I have a WIP patch posted already.
  • bug 1021478 - Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • We now have a correct solution according to Carrie, so I'm going to clean this up and take it into review.
  • bug 911055 - [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>>
    • Need to review this for David. I took a cursory look at this and it looks great.
• Done:
  • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
    • Can't repro on Flame / master, asked for qawanted.
  • bug 1037868 - Create gaia-sim-picker component
    • I've posted a WIP patch where I'm blocked on what :kgrandon believes may be a platform issue.

Rik

• Still into bug 967440, working on the unit tests. A lot of tests for FontSizeManager are missing :(

gtorodelvalle

• Administrative:
  • Nothing to report
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Retook this bug.
  • Filed a new one I found (see next).
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • Need-infoed Carol asking for visual specs.
  • Working on this bug. The main problem I found is that |APP=callscreen make install-gaia && adb shell stop b2g && adb shell start b2g| no longer work and I have to run |make install| (which takes ages) instead :( Hopefully bug 1000049 will land soon :)
  • <drs> I tried this and it worked fine for me. I tried looking into a way to run the callscreen as its own app but it seems pretty heavily embedded in the system app (see dialer_agent.js).

thills

Wasabi device - Sprint says they cannot take a device that is not "made for sprint". They scanned the MEID and IMEI and said that the only way to get it to work is to have it added to their database. Verizon has a website where you can figure out whether it will work by adding IMEI and MEID. I entered both of these and it says that the device will not work with Verizon.

• bug 1039643 - Still in progress. Not ready for review yet.

pacorampas

• Absent/no report

Day 3: July 24

Meeting Minutes

10:30 drs: hi all, Rik davidg gsvelto thills 10:30 thills: hi drs 10:30 drs: ok, let's get started 10:31 drs: on the admin side, I tried getting the wasabi device connected to 3 carriers here and none of them said they could support it 10:31 davidg: hi 10:31 drs: I asked for as much info as possible, to the point that one of them asked me to leave because I was asking too many questions after he told me it wouldn't happen, haha 10:31 thills: drs I talked to sprint here and they can support… but only on a plan 10:31 gsvelto: hi 10:31 Rik: I don't know why I did not think about this first but you should talk to QA about CDMA in North America, they would know about this 10:31 drs: oh, great 10:31 drs: Rik: we already tried that 10:32 drs: thills: maybe if worse comes to worse I can get a sprint plan and roam with it 10:32 thills: you have to call around  :) You might get sales people that don't understand… and wnat to seell you a phone 10:32 thills: I'm still looking for sth cheaper though 10:32 drs: ok, I went into the stores, one of them actually knew about cdma and explained stuff to me 10:32 Rik: I guess you are only CDMA hope Obi Wan thills 10:33 thills: lol 10:33 drs: well I'll call instead, maybe that will work better 10:33 drs: that's it for admin for me. any other admin updates? 10:33 gsvelto: thills, you can always expense that with Mozilla BTW 10:33 Rik: I even say s/can/should/ 10:34 gsvelto: yeah 10:34 thills: gsvelto, yes. I figured that but it seems a little steep… so I still want to find cheaper 10:34 drs: I think unless it's like $500/mo it would still be worth being able to test CDMA 10:34 drs: and even then it would probably be worth it 10:34 thills: drs: it's $55/month 10:34 drs: ok, as for my update, I'm going to get started on bug 1039553 10:34 firebot: https://bugzil.la/1039553 — NEW, drs+bugzilla — [Dialer][Call Screen] It's not possible to start a second call 10:34 drs: thills: that's really not that bad, especially if it gives you data and texting, then you can test everything you need 10:35 drs: that's it for my update. Rik 10:35 gsvelto: thills, it's a bit steep but ask David for approval and I think you'll get it, as drs said being able to test a CDMA device is a huge plus for us 10:35 Rik: thills: don't even think about it if it's 55$ ! 10:35 drs: gsvelto: that's not actually steep for NA 10:35 drs: well, it depends on what's included 10:35 Rik: I'm in my reflow bug 967440, will try to get a patch tonight 10:35 firebot: https://bugzil.la/967440 — ASSIGNED, anthony — Remove some reflows on the keypad 10:35 thills: yes, will ask. it was 55 for voice & data 10:36 Rik: (it works in keypad, need to work in callscreen and verify tests) 10:36 drs: Rik: regretting taking that one? 10:36 Rik: that's it for me 10:36 drs: davidg 10:36 Rik: drs: not really :) had to be done 10:36 davidg: hi, I submitted a patch for bug 911055 10:36 firebot: https://bugzil.la/911055 — NEW, david.garciaparedes — [zffos1.1][P3][Dailer]DuT doesn allow to dial a <<pause>> 10:36 davidg: :drs etienne set you on review 10:36 Rik: drs: and I'll be happy to mark it resolved fixed, finally! 10:37 drs: davidg: oh, I missed that somehow, thanks 10:37 drs: I'll review it soon 10:37 drs: davidg: is that all for your update? 10:37 davidg: on bug 995938 I still need to get approval if the tone needs to be played in conferences 10:37 firebot: https://bugzil.la/995938 — NEW, david.garciaparedes — Device does not play an 'end tone' when the call is finished 10:38 drs: davidg: approval from whom? 10:38 drs: it looks like patryk said to go ahead 10:38 davidg: and on bug 976678 Marco Chen wants me to check if it works ok with voip/loop calls 10:38 firebot: https://bugzil.la/976678 — UNCONFIRMED, david.garciaparedes — [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep. 10:38 drs: ah, waiting for carrie, ok 10:38 davidg: yes carrie :) 10:39 drs: ok, is that everything for you? 10:39 davidg: thanks. that's all for me :) 10:39 drs: ok, gsvelto 10:40 drs: we might be having baby problems 10:40 drs: let's move on to thills for now 10:40 thills: I'm still working on bug 1039643. Trying to get something for feedback in next day or so. That's it from my side 10:40 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js 10:41 drs: ok, I saw gsvelto took bug 1042304 10:41 gsvelto: sorry 10:41 firebot: https://bugzil.la/1042304 — ASSIGNED, gsvelto — [B2G][Dialer] When creating a new contact from an unknown phone number, adding a photo from the gall 10:41 gsvelto: I'm here 10:41 gsvelto: yeah, I've taken that one and landed bug 1006592 10:41 firebot: https://bugzil.la/1006592 — FIXED, gsvelto — While sending USSD code, last dialed number by user appears in dialer app 10:41 drs: ok, no more terrible uplifts? 10:41 gsvelto: I'm trying to figure out what's happening in bug 1042304 but I haven't pinpointed a cause yet 10:41 gsvelto: drs, no, not after yesterday :) 10:42 gsvelto: and this is it 10:42 drs: ok, that's a wrap, thanks everyone

drs

• Admin:
  • I went to the stores of a couple of carriers nearby to try to get the Wasabi CDMA device connected to a network here and it's not looking good. I need to contact Wesley but I don't think this is actually possible.
• Next steps:
  • bug 1037868 - Create gaia-sim-picker component
    • Working on this now.
    • This is going to take a while. I spent some time yesterday talking with kgrandon and wilsonpage about this. You can check out our notes here: https://etherpad.mozilla.org/web-components
  • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
    • Will do this in parallel with bug 1037868, haven't started yet.
    • <Rik> That sounds higher priority to me, we should discuss
    • It is, I'm going to do it today.
• Done:
  • Uplifted bug 1018494 and bug 1035183 to 2.0
  • bug 1006592 - While sending USSD code, last dialed number by user appears in dialer app
    • Review+ for Gabriele, checkin+

Rik

• Deep into bug 967440, remove reflows. I'm seeing the end of it but not there yet. I hope to submit a patch tonight.

gtorodelvalle

• Administrative:
  • I WON'T BE ABLE TO JOIN THE MEETING July 24 :-(
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Approval granted.
  • New rebasing needed and TBPL reporting only errors not related to this patch.
  • Asked Ryan about how to proceed (if I should land it in v2.0) or there are sheriffs for that. Waiting for his reply ;)
  • Authorised by Ryan to merge the patch in v2.0, aaand merged! ;)
• bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list:
  • Retook this bug.
  • Filed a new one I found (see next).
• bug 1043347 - [Dialer][Call Screen] Bad alignment of information in conference call overlay:
  • Need-infoed Carol asking for visual specs.

thills

• bug 1039643 - Still working on this. Hope to have something for feedback in next day or so.
• bug 998147 - drs has landed the gaia portion for me.

pacorampas

• Absent/no report

Day 2: July 23

Meeting Minutes

10:30 drs: hi everyone, looks like it's standup time. Rik davidg1 (I remembered this time) gsvelto gtorodelvalle thills 10:30 gsvelto: hi everybody 10:30 gtorodelvalle: Hey! :) 10:31 drs: ok so admin items 10:31 drs: thills and I now have wasabi devices 10:31 drs: which are the only cdma devices that we have 10:31 drs: I've been doing research to get it connected to a network here, but it's not looking good. I'm going to go to a store later today and see what they say 10:31 thills: drs I'm looking around to see if I can get a prepaid setup 10:31 drs: if anyone knows about cdma here it would be really helpful if you could give any info 10:32 gsvelto: drs, thills excellent, if you need a crash course on the current CDMA support just ask me because I wrote all of it 10:32 drs: gsvelto: ok that would be really helpful. maybe we should schedule something for the 3 of us 10:32 drs: we'll talk about that after 10:32 gsvelto: and since I didn't have a device to test I did everything against the specs & with unit-tests 10:32 drs: right 10:32 drs: that's it for my admin updates, gtorodelvalle has one too 10:33 gtorodelvalle: Just mentioning that whenever you consider it appropriate do not hesitate to contact me for IRC-reviews ;) since I feel bad going through many iterations of your comments :D 10:33 drs: ok, any more admin? 10:34 drs: my update: I again have nothing to draw attention to. I've been pretty light on reviews lately though so feel free to ask me for review if you need it (though remember I'm not a peer yet so it should probably go through Rik first) 10:34 drs: next is Rik 10:35 Rik: I think we should move to using a datastore for call log insertion, opened bug 1042576 about it 10:35 firebot: https://bugzil.la/1042576 — NEW — Move the insertion in call log to a datastore 10:35 Rik: the bug contains the reasons why I think it's a good idea 10:35 drs: seems like something we could take next sprint 10:36 Rik: if you have ideas for or against this, please say so there 10:36 Rik: (ping etienne_s for that) 10:36 drs: Rik: please remember to update this: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Long-Term_Project_Ideas 10:36 Rik: that's it for me 10:36 drs: since we don't have every idea having a bug yet, we should keep them in sync 10:36 drs: once we have all the ideas either rejected or filed as bugs, we can remove that list 10:36 drs: next is davidg1 10:37 Rik: done 10:37 drs: thanks 10:37 davidg1: Hi, I have been looking at bug 976678. I am going to propose this patch https://github.com/mozilla-b2g/gaia/pull/22075. I will ni mchen and julienw, because they said it wasn't possible to use telephony channel from system 10:37 firebot: https://bugzil.la/976678 — UNCONFIRMED — [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep. 10:37 drs: is that something anyone here would know about? 10:37 davidg1: but I tried, and it works perfectly… so maybe I'm missing something 10:38 davidg1: done :) 10:38 drs: ok, gsvelto ^ not sure if you would know, but let's move on 10:38 drs: anyways it's your update time regardless 10:38 gsvelto: still working on bug 1002327 10:39 firebot: https://bugzil.la/1002327 — FIXED, gsvelto — We are trying to get imei by dialing the number *#06# on a device, which has two sim card slots, bu 10:39 gsvelto: I had to prepare a v1.3t uplift that used callbacks instead of promises (ugh) 10:39 gsvelto: I hope this is the last one 10:39 drs: fun 10:39 gsvelto: and I went through the first iteration with bug 1006592, I'm now preparing what I hope will be the final patch 10:39 firebot: https://bugzil.la/1006592 — ASSIGNED, gsvelto — While sending USSD code, last dialed number by user appears in dialer app 10:39 Rik: davidg1: you should put your patch on the bug and ask for feedback 10:39 gsvelto: and this is pretty much it 10:40 Rik: gsvelto: the bug is 1.4+, why a 1.3t patch? 10:40 drs: Rik: yeah, he said he's going to propose that patch 10:40 gsvelto: Rik, because I should have fixed that bug in another one which was a 1.3T+ 10:40 drs: Rik: it's a regression from bug 990003 10:40 firebot: https://bugzil.la/990003 — FIXED, etienne — [Dolphin][Tarako][Perf][Dialer] It takes a long time for the call screen shows up 10:40 gsvelto: Rik, but I misunderstood the scope of the original bug and so the fix ended up split in two different bugs 10:41 Rik: gsvelto: have you verified that this will be taken in 1.3t? wouldn't want you to work on something that relman refuses 10:41 gsvelto: and I'm actually mixing things up, the uplift I'm preparing is for bug 1019783 10:41 firebot: https://bugzil.la/1019783 — FIXED, gsvelto — Output from *#06# on FLAME DIALER used to return 2 IMEI 10:41 gsvelto: and should have been in bug 1002327 10:41 gsvelto: it's requested by a vendor for certification so that's why I'm doing it 10:41 davidg has joined (Adium@53EF5629.3416E031.E21948B5.IP) 10:41 davidg1 has left IRC (Connection reset by peer) 10:42 gsvelto: these uplits are driving me nuts 10:42 drs: yeah... 10:42 drs: ok, let's move on 10:42 mariaoteo has joined (mariaoteo@moz-F6843A97.red-83-61-225.dynamicip.rima-tde.net) 10:42 drs: gtorodelvalle 10:42 gtorodelvalle: On my side just mentioning and sharing, mainly with Doug, that I will land the patch for bug 1010104 as soon as this meeting finishes since after 3 re-runs of a Travis task that got stuck, the only failure is due to a third party app. The rest is in the Etherpad page :) 10:42 firebot: https://bugzil.la/1010104 — ASSIGNED, gtorodelvalle — [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size 10:43 drs: gtorodelvalle: link please? 10:43 gtorodelvalle: If no comments, next is thills :) 10:43 thills: bug 998147 landed on mozilla-central, but I believe (someone correct me if I'm wrong) that we need it to land on the release branch as well before we land the gaia portion. 10:43 firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call 10:43 drs: thills: I took a look at it, and it doesn't look like it would break anything to land the gaia portion even if the gecko portion isn't landed 10:43 drs: but we can wait anyways, there's no rush 10:43 drs: it should get merged into central soon 10:43 thills: ok, yeah, let's wait 10:44 Rik: (I'll have one more admin note) 10:44 thills: and then still working on unit tests 10:44 thills: and that's it from my side 10:44 drs: thills: Bug 1039643 10:44 firebot: https://bugzil.la/1039643 — ASSIGNED, thills — Write some unit tests for shared/js/dialer/contacts.js 10:44 drs: Rik: go ahead 10:44 Rik: thills: 998147 is already on central, so you can land the gaia part 10:45 Rik: admin notes: we plan to turn off Travis pull request builds (see m.d.gaia). so you should get used to watch Gaia-try more than travis now 10:45 drs: oh yeah, look at comment 35 10:45 drs: ok thanks Rik 10:45 drs: meeting over, thanks everyone 10:45 drs: btw, if anyone needs help with gaia-try, let me know 10:45 gsvelto: thanks! 10:46 drs: it's a bit different than travis

drs

• Admin:
  • I have a Wasabi device now (our only CDMA one) and I believe Tamara does too. I've been doing some research on it and I'm going to try to get it on a network.
• Next steps:
  • bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
    • Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
  • bug 1037868 - Create gaia-sim-picker component
    • Working on this now.
  • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
    • Will do this in parallel with bug 1037868, haven't started yet.
• Done:
  • Researched CDMA a bit.
  • bug 998147 - [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call
    • Review+ for Tamara
  • bug 1006592 - While sending USSD code, last dialed number by user appears in dialer app
    • Review- for Gabriele

Rik

• Reviews
• UX mock up for the Call log duration
• Opened Facebook follow up for suggestion bar bug 1042562 and migrate call log insertion to data store bug 1042576. I think the datastore one will have a great impact.

gtorodelvalle

• Administrative:
  • As a suggestion and although I would say it is more Doug's than mine, when possible I think we should probably try to run IRC-reviews in parallel with using Github or Bugzilla since it speeds the landing up a lot :) At least to fully understand the requests of the reviewer (and that's mainly on me :) ).
    • <drs> I think our current system is fine. I generally ask for IRC review when I want to get something landed quickly or I feel bad about it and don't want to waste more of someone's time. Remember that IRC reviews are sync so it's more costly for the reviewer.
    • In fact, I would say it is more costly for the submitter since it is the reviewer the one who decides when to run it :p But I am fine with it ;) Sometimes I find myself wanting to ask something to the reviewer and I have to leave my comments in Github and wait the next round :)
    • <drs> Yeah, in that case it's fine to ask on IRC, but doing a full IRC review as much as possible seems like overkill to me.
    • Totally agreed ;)
  • (just informative) Paco's patches with third party apps failing tests landed in master.
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Mari Ángeles has asked Stephany to try to push it forward ;)
• bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
  • Currently including Doug's comments in the patch.
  • Implemented the new version with no getScenario() as suggested by Doug.
  • Asked revision to Doug about the new version. New revision asked ;)
  • r+ by Doug. Waiting for the tests to pass to land it in master.
• bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
  • Implemented Anthony's suggestions.
  • Asked for a new revision.

pacorampas

• bug 1023246 - [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.
  • Working on this
  • Testing number and time of reflows
• bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
  • Working on visual part
  • I am testing with pau a new hit state

thills

• bug 1039643 - Still working on this.
• bug 998147 - The gecko portion is landed. review is done for gaia portion and ready to go.
  • <drs> Do you need this landed?

Day 1: July 22

Meeting Minutes

10:30 drs: hi all, looks like it's standup time 10:30 drs: Rik, gsvelto, gtorodelvalle, thills 10:30 thills: HI DRS 10:30 gtorodelvalle: Hey! :) 10:30 thills: sorry for caps 10:30 drs: heh 10:30 Rik: THAT'S OK THILLS! 10:30 drs: ok, let's get started 10:30 drs: ON THE ADMIN SIDE, WE HAVE NOTHING NEW 10:31 Rik: there is something 10:31 drs: ok, go ahead 10:31 Rik: I think we should populate https://wiki.mozilla.org/FirefoxOS/Comms/Dialer/Sprint/v2.1-S1#Demos as we go 10:32 drs: ok, cool 10:32 Rik: it's easy to take screenshots/videos while we work on something 10:32 Rik: not so when you need to do it at the end of a sprint 10:32 drs: yeah, makes sense. looks like gtorodelvalle also has admin items on the etherpad 10:32 Rik: if we have enough demos, we could blog about them (or a subset) 10:32 thills: so, this is mainly for features, right? 10:32 gtorodelvalle: Yeap 10:32 Rik: thills: or bad bugs 10:32 drs: thills: features and any blockers that make a big difference 10:32 gtorodelvalle: Ups, sorry, I “yeap” drs :) 10:33 Rik: thills: let's do everything ! :) 10:33 thills: heh… screenshots of new unit test logs? 10:33 gtorodelvalle: Yeah, “previously in Dialer…” and the latest updates :) 10:33 Rik: thills: your notification bug is very demo-able 10:33 drs: including bug 1039643 10:33 firebot: https://bugzil.la/1039643 — NEW, thills — Write some unit tests for shared/js/dialer/contacts.js 10:33 gsvelto: hi there 10:33 gsvelto: I'm slightly later 10:33 drs: heh, I think we should keep it to bugs that have visible impact to the end user 10:34 gsvelto: *late 10:34 Rik: thills: you can screenshot 0 tests -> over 9000 tests! :D 10:34 thills: hehe 10:34 gtorodelvalle: passing, right? 10:34 drs: actually, does anyone feel that having demos of every bug would be motivating? 10:34 drs: (some people on other teams said this) 10:34 Rik: I'm kind of jealous of SMS demos so yup :) 10:34 gtorodelvalle: If it has a visual impact I would say yes 10:34 gsvelto: that depends on how long it takes to make the demo 10:35 drs: how about we set a minimum requirement then 10:35 drs: if it has end user impact, we require a demo 10:35 drs: but if you want to do one, you can do it even if it doesn't 10:35 gsvelto: sounds good 10:35 gtorodelvalle: +1 10:35 drs: ok 10:35 drs: gtorodelvalle: you also had some admin items 10:35 gtorodelvalle: I just included a couple of issues on the Etherpad related to a couple of bugs with third party apps test failing and was wondering if you guys want us to check with you or just go ahead and land them :) 10:36 gtorodelvalle: They were Paco’s patches 10:36 drs: if you're not sure, it's best to check with us 10:36 gtorodelvalle: ;) 10:36 gtorodelvalle: On the other hand… 10:36 drs: it won't really hurt to merge a patch a day late if there's no deadline 10:36 drs: but if you're sure it's unrelated, then you can go ahead and merge 10:36 gtorodelvalle: I just was told that the sprint planing took place at 11:00 or at least the retrospective, is that right? 10:36 drs: ? what do you mean 10:36 gtorodelvalle: I had no entry in my agenda :( in case you could forward it to me 10:37 drs: sorry, you lost me 10:37 Rik: yes, it was this morning at 11 10:37 gtorodelvalle: Today at 11 10:37 gtorodelvalle: Yeap :D 10:37 Rik: https://etherpad.mozilla.org/comms-retrospect-demo 10:37 gtorodelvalle: I lost it too :p 10:37 drs: oh, the comms retrospective, ok 10:37 Rik: wesley will re-send it 10:37 gtorodelvalle: Great! Thanks! 10:37 gtorodelvalle: That’s all on my side regarding administrave issues 10:38 drs: ok 10:38 drs: so as for my update 10:38 drs: I have nothing to draw attention to, I'm just gonna put my head down and work on some bugs listed on etherpad 10:38 drs: Rik 10:38 drs: davidg1: sorry, forgot to ping you at the beginning, hi 10:38 wesley_huang has left IRC (Quit: wesley_huang) 10:39 Rik: nothing to highlight either, I'll start working on the reflow stuff once I'm done with my last review 10:39 davidg1: drs: no problem :) 10:39 Rik: next? 10:39 drs: ok, davidg1 10:39 davidg1: I'm currently looking at bug 976678 10:39 firebot: https://bugzil.la/976678 — UNCONFIRMED — [zffos1.3][P3](Local) During voice calls the sound alert for new SMS does not beep. 10:40 gtorodelvalle: DJ David1 :O 10:40 drs: davidg1, is that everything? 10:40 davidg1: I'm thinking about letting the callscreen app play the notifications using the telephony channel 10:41 drs: do you want feedback on that? 10:41 davidg1: yes I will like to ask someone about that 10:41 drs: who is best to talk with about that? gsvelto? can you guys talk about it after, we're running out of time 10:41 Rik: davidg1: you could needinfo Carrie on this 10:41 davidg1: Rik: cool, I will 10:41 davidg1: next? 10:41 drs: ok, gsvelto 10:41 gsvelto: I just finished massaging the unit tests for bug 1006592, I'm going to submit the patch for review soon 10:41 firebot: https://bugzil.la/1006592 — ASSIGNED, gsvelto — While sending USSD code, last dialed number by user appears in dialer app 10:42 gsvelto: and this is pretty much it 10:42 gsvelto: at least for today :) 10:42 gtorodelvalle: Everthing on track on my side (also on Paco’s :) ) and detailed on the Etherpad page :) 10:42 drs: ok, thills 10:42 gtorodelvalle: Next is thills 10:42 thills: From my side, I was working on pull reuqest for bug 998147 and managed to overwrite the changes with a merge :( I think a 5 min IRC will help me understand what best practice is for this scenario… maybe rik or gsvelto? And then started working on bug 1039643 10:42 firebot: https://bugzil.la/998147 — ASSIGNED, thills — [Dialer] A Missed Call notification is given when chosing to hang up on an incoming call 10:43 gsvelto: thills, you mean you overwrote your changes? 10:43 drs: ok thanks, meeting over (you can talk about that now)

drs

• Admin:
  • Nothing new.
• Next steps:
  • bug 1035183 - Matching numbers screen results is not properly localized for 10+ matches
    • Backed out of 2.0 and waiting for bug 1018494 to be uplifted before re-uplifting it.
  • bug 1037868 - Create gaia-sim-picker component
    • Working on this now.
  • bug 1039553 - [Dialer][Call Screen] It's not possible to start a second call
    • Will do this in parallel with bug 1037868, haven't started yet.
• Done:
  • bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size
    • Reviewed for Germán, review+
  • bug 1021478 - [1.4] Set outgoing calls "Always ask" with two sim card inside, use bluetooth headset to dial, there will be no network message
    • Figured out some test failures for Wei.

Rik

• admin : I added a Demo section on our sprint page, I intend to fill it as I go
• Sprint planning
• Reviews

gtorodelvalle

• Administrative:
  • Paco's patch for "bug 1030623 - [Dialer] No space between text and border when Contact with long name and number matching hits" can be landed since the tests failing has nothing to do with the proposed patch.
  • Paco's patch for bug 1033937 - "[Calllog] Tap on Withheld number in call log, item highlighted, but stay highlighted when finger released" can be landed since the tests failing has nothing to do with the proposed patch.
  • Should we directly merged them or do you prefer us to cross check it with you? You know I get scared when I see Travis in red :p
• bug 1018283 - [Follow-up 951665] Pending visual revision and adjustments of the VR call screen when in lockscreen:
  • Mari Ángeles has asked Stephany to try to push it forward ;)
• bug 1010104 - [Dialer][Call Screen] Baseline of the contact name when applying the fluid font size:
  • Currently including Doug's comments in the patch.
  • Implemented the new version with no getScenario() as suggested by Doug.
  • Asked revision to Doug about the new version. New revision asked ;)
• bug 1030623 - [Dialer] No space between text and border when Contact with long name and number matching hits:
  • Solving some issues with the tests. In fact, not related to the proposed patch.
• bug 1024506 - While call is "connecting", "Add other call", "Keypad" and "microphone" buttons should be disabled:
  • Implemented Anthony's suggestions.

pacorampas

• bug 1023246 - [Flame][v1.4][Gaia::Dialer]The contact’s photo is shown incompletely in the call log edit screen.
  • Working on this

thills

• bug 1039643 - Started looking on this to add the unit tests for the contacts.js
• bug 998147 - Spent some time on trying to figure out how to merge this with the previous bug I was working on since the changes are in the same area. Will probably just create a new branch for this.

Retrospective

Retrospective Etherpad

Things we did well

• <drs> The team is starting to feel like a unified force instead of a loosely related group.
• <drs> The daily standup seems to still really be helping and we've ironed out a bunch of details (though see below).
• <drs> We got our blockers down to 0 and were the first comms subteam to do so.

Things we could do better

• <drs> Switching the standup host every day is cumbersome and doesn't allow people to get better at it.
• <drs> Sprint planning was really weak, I should have prepared better.
  • <drs> Between blockers and reorganization, I had very little time to spend figuring out what to do next. I'm happy we did get started on the sheet navigation prototype, though. This won't be a problem this sprint.
  • <Rik> I think dialer-most-wanted will help a lot.
• <drs> We are not doing a good job keeping everyone involved in long-term projects. In particular, we're not getting enough feedback or ideas. Now that we've cleared our blockers and we're not really under any serious pressure, we should be able to step back and think about these things.
  • <drs> Suggestions? What would get you more involved?
• <gtorodelvalle> In this sprint we at Telefónica had many distractions from what was previously agreed as work to be done during the current sprint planning (IOT and certification guys' requests).

Action items

• <drs> Switch standup host to weekly rotation. (thills' idea)
• <drs> I think we should start doing demos of significant features/bug fixes.
• <drs> I also think we should start setting time aside to improve our technical documentation. This is all we have right now: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Feature.2FSubcomponent_Documentation
  • <gsvelto> We should also document our code better, our in-code documentation currently leaves a lot to be desired (which is an euphemism for complete absence of comments in the code). As a side note we could explicitly start asking for better in-code documentation in reviews.
    • <gsvelto> Enforce documenting stuff that you touch.
• <gtorodelvalle> We need a way to proceed in the presence of not previously considered bugs, mainly coming from IOT and certification guys at Telefónica. Probably raising the issue when they pop up and consider any needed rescheduling for the sprint.
  • <drs> Can we talk about these as they come up? At the daily standup.
  • <gtorodelvalle> Absolutely ;)

Demos

1. Bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list: (in fact the video is not 100% correct since the call duration which should be shown is the conference call duration when the participant leaves the conference, this is already included into the patch but bug 1048285 impedes recording it correctly :( )

https://www.youtube.com/watch?v=iF1K2DovRV8