Firefox OS/Comms/Dialer/Sprint/v2.1-S4
From MozillaWiki
< Firefox OS | Comms | Dialer | Sprint
Contents
Bugs
Status
- 19,19,16,13,15,13,8,6,6,5
Bugs Taken in Planning
| ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
|---|---|---|---|---|---|---|---|
| 980854 | Gabriele Svelto [:gsvelto] | Remove the workaround for glitchy touch tones introduced implemented bug 917193 | --- | No cf_feature-b2g | [planned-sprint] | RESOLVED | FIXED |
| 1030631 | Jorge Prudencio [:jorgep] | [Dialer] Text not aligned when matches are more than 1 if contact has long name | --- | No cf_feature-b2g | [priority][planned-sprint][in-sprint=v2.1-S3] | RESOLVED | FIXED |
| 1038846 | Jorge Prudencio [:jorgep] | [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message | 2.0M+ | No cf_feature-b2g | [planned-sprint][in-sprint=v2.1-S3] | RESOLVED | FIXED |
| 1060729 | Tamara Hills [:thills] | Handle default outgoing call SIM set to "always ask" in ICE contacts | 2.1+ | No cf_feature-b2g | [planned-sprint] | VERIFIED | FIXED |
| 1061120 | David Garcia [:davidg][retired] | [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information' | 2.1+ | No cf_feature-b2g | [planned-sprint c=3] | VERIFIED | FIXED |
| 1061149 | Doug Sherk (:drs) (inactive) | [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen) | 2.1+ | No cf_feature-b2g | [planned-sprint] | VERIFIED | FIXED |
| 1061463 | Tamara Hills [:thills] | Call log info must not reuse the string "Missed" | 2.1+ | No cf_feature-b2g | [planned-sprint] | VERIFIED | FIXED |
7 Total; 0 Open (0%); 3 Resolved (42.86%); 4 Verified (57.14%);
- Does not include Bugs Taken but not Completed.
Bugs Taken but not Completed
| ID | Assigned to | Summary | Blocking b2g | Feature-b2g | Whiteboard | Status | Resolution |
|---|---|---|---|---|---|---|---|
| 1061616 | Anthony Ricaud (:rik) | call log is not showing recently dialled numbers | 2.1+ | No cf_feature-b2g | [fromAutomation] [planned-sprint c=3][in-sprint=v2.1-S4][2.1-flame-test-run-2] | VERIFIED | FIXED |
1 Total; 0 Open (0%); 0 Resolved (0%); 1 Verified (100%);
Bugs Taken During Sprint
10 Total; 0 Open (0%); 8 Resolved (80%); 2 Verified (20%);
All Issues for this Sprint
17 Total; 0 Open (0%); 11 Resolved (64.71%); 6 Verified (35.29%);
- Does not include Bugs Taken but not Completed.
Bugs Redirected
9 Total; 0 Open (0%); 4 Resolved (44.44%); 5 Verified (55.56%);
Daily Standup Meetings
- Current hosts: drs, gtorodelvalle, thills
- Hosts rotate every week.
- If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
- Start by pinging everyone who should be participating.
- List any administrative items you have, and then ask for more from other people (look at the Etherpad).
- Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
- Move to individual updates. Go alphabetically, in descending order.
- If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
- Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
- Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.
Day 10: September 15
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
drs
- Admin:
- Nothing new.
- Next steps:
- I will not be coding anymore this sprint and will start planning for the next sprint, doing reviews, and planning long-term projects.
- bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
- The reporter found an edge case that we didn't account for. David will have to update this and I'll review it again.
- bug 1053641 - [b2g][2.0] "call forwarding status" page string format has problem.
- Reviewed for Gabriele, but there's a new version up that I need to review with some re-enabled tests.
- bug 1037868 - Create gaia-sim-picker component
- Need to fix this after Anthony's high-level comments.
- Done:
- Did sprint pre-planning.
- Overhauled wiki main page: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Got approval for v2.1 with bug 1030346.
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Landed the uplift to v2.1 for Jorge.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Review- for Jorge.
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- German is helping me for fix it some comments of Doug's Review
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- bug 1061398 - Incall keypad layout needs adjustment
- I have asked for feedback to Doug because I think there are different approaches
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Landed yesterday.
- requested permission for 2.1.
- bug 1024341 - Wakeup the device after call hangs up
- Clarifying question out to Carrie on this one about what UX should be.
- I'm at a point where I might need some help to discuss different approaches right now.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
jpruden92
- Absent/no report
Day 9: September 12
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
drs
- Admin:
- Nothing new.
- Next steps:
- I will not be coding anymore this sprint and will start planning for the next sprint, doing reviews, and planning long-term projects.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Need to review this for Jorge.
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Reviewed and landed a patch for David to get this into a different format.
- I decided to request uplift for this even though nobody is sure about the correct format. It has been approved. Needs a branch patch for v2.1.
- Done:
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Requested uplift. This is a bit messy due to bug 1030346.
- bug 1061421 - [Contacts] Delete all contacts which were set to ICE, 'ICE contacts' list is empty but the whole ICE section should be removed
- Review+ for Francisco, landed.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Review- for Paco.
- bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
- Review- for David.
- Went over how to handle Gaia push permissions and general Git stuff with Tamara.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I am checking the new review.
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- bug 1061398 - Incall keypad layout needs adjustment
- I take it.
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Landed yesterday.
- requested permission for 2.1.
- bug 1024341 - Wakeup the device after call hangs up
- Clarifying question out to Carrie on this one about what UX should be.
- I'm at a point where I might need some help to discuss different approaches right now.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
jpruden92
- Absent/no report
Day 8: September 11
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
drs
- Admin:
- Anthony is on PTO until Tuesday, so please redirect any review requests to me.
- I will not be coding anymore this sprint and will start planning for the next sprint, do reviews, and plan long-term projects.
- Next steps:
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Have to review this for Paco.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Done:
- bug 1060725 - Audit test coverage of ICE contacts
- Landed.
- bug 1062749 - [Dialer] Make prettyDuration use l10n attributes instead of setting textContent. Follow up bug 1061120
- Landed for David.
- Carrie is going to check with the world-ready mailing list what the format should be here.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Got review+ from Francisco. Did a followup after and landed it.
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Review+ for Tamara, landed as well.
- bug 1060725 - Audit test coverage of ICE contacts
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Landed yesterday.
- this is now a 2.1 blocker so will ask for permission for 2.1.
- bug 1024341 - Wakeup the device after call hangs up
- Working on this now. Nothing seems to wake up the screen so far, so still playing with this trying to find a method that works.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
davidg
- Absent/no report
Day 7: September 10
drs
- Admin:
- Today is our first office hour day!
- Next steps:
- bug 1060725 - Audit test coverage of ICE contacts
- Posted a patch.
- bug 1037868 - Create gaia-sim-picker component
- Posting a patch with Anthony's suggested changes today.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Have to review this for Paco.
- bug 1060725 - Audit test coverage of ICE contacts
- Done:
- bug 1062749 - [Dialer] Make prettyDuration use l10n attributes instead of setting textContent. Follow up bug 1061120
- Review+ for David.
- bug 1060723 - Call info page isn't updated after a call dispatched from it ends
- Review+ for Anthony.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Got review+ from Francisco.
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Review- for Tamara, new version up for review.
- bug 1062749 - [Dialer] Make prettyDuration use l10n attributes instead of setting textContent. Follow up bug 1061120
Rik
- Admin:
- We should take a look at our sprint status to see which bugs need more attention to try and complete all bugs. That will give us a feeling of completion.
- I'm on PTO starting tomorrow till Tuesday
Updates:
- Triaging new bugs
- landed bug 1060723
- Taking bug 1042562 - Remove facebook specific code from suggestion_bar.js
- Reviews:
- bug 1060725
- bug 1037868 first pass
- bug 1038846
pacorampas
- Tomorrow is a free day in Barcelona.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I have done the suggestions that Doug has proposed on review. And I'm waiting for new cicle of review.
- <drs> Just FYI, you forgot to set the review flag.
- bug 1044996 - [Dialer][Call screen] New hit state for call screen options (mute, place new call, keypad...)
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
- bug 977056 - [Dialer] Visual discrepancies: Call ended view under conference call participants list
- I have not advanced much on this bug and German is back Monday. I think the best options is that German take it.
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Latest patch for review
- bug 1024341 - Wakeup the device after call hangs up
- Took this one from most-wanted.
- Looking at it now. Will set it to assigned shortly.
- Working on a gecko bug in the meantime
gtorodelvalle
- Absent/no report
davidg
- Absent/no report
Day 6: September 9
Blockers
- bug 1061616 - call log is not showing recently dialled numbers
- QA reproduction attempt was inconclusive. We should continue trying to reproduce it ourselves.
drs
- Admin:
- Anthony and I were promoted to co-owners of the dialer! You can now request reviews directly from me.
- Use the "suggested reviewers" button as it tells you how many reviews each person is currently juggling.
- Tomorrow will be our first office hour day.
- Anthony and I were promoted to co-owners of the dialer! You can now request reviews directly from me.
- Next steps:
- bug 1060725 - Audit test coverage of ICE contacts
- Will have a patch today.
- Will take more tech debt bugs and begin scoping out more long-term work.
- bug 1060725 - Audit test coverage of ICE contacts
- Done:
- bug 1060723 - Call info page isn't updated after a call dispatched from it ends
- Review- for Anthony.
- bug 1064239, bug 1064234
- Quick punts to contacts.
- bug 1041879 - Remove dead 'useNewStyle' code from shared/js/lockscreen_slide.js
- We have a plan now that everyone agrees to, and we seem to have at least mostly resolved the misunderstandings here.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Waiting for Francisco to review.
- bug 1040922 - Refactor SimPicker such that it triggers MutationObserver on updates
- Landed.
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Did a mini-review.
- bug 1060723 - Call info page isn't updated after a call dispatched from it ends
Rik
- bug 1060723 posted a first version. We discussed the best way to go about this, will have another patch today
- bug 977056 Asking feedback from our RIL team on event ordering
- bug 933596 Checking with UX if we can close this
- bug 977588 Asked feedback from Gabriele on the CDMA case
- Reviews:
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I have done the suggestions that Doug has proposed on review. And I'm waiting for new cicle of review.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Finished incorporating feedback from drs and rik. Will put patch for review as soon as I finish testing.
- Working on a gecko bug in the meantime
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
- Tested on ICE contacts and changed solution. Waiting to review.
- Merged
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Patch made. Waiting to review.
- Improving the solution. Modifying tests.
gtorodelvalle
- Absent/no report
davidg
- Absent/no report
Day 5: September 8
Blockers
- [2.1?] bug 1063785 - [Flame] [2.1] Dialer volume does not respond to changes in volume.
- Nobody has looked at this yet. Maybe this is some kind of tone channel issue? Suggested: Gabriele
- This is a dupe.
- Nobody has looked at this yet. Maybe this is some kind of tone channel issue? Suggested: Gabriele
- bug 1038701 - [US] Support for ICE Contacts in Lockscreen/Emergency call
- bug 1064239 - [Contacts] Once delete a ICE contact, this contact appears in settings.
- drs will look into this.
- bug 1064234 - [Contacts] When ICE contact's name is long, Setting menu isn't correctly visible
- drs will look into this.
- bug 1064239 - [Contacts] Once delete a ICE contact, this contact appears in settings.
- [2.1?] bug 1063785 - [Flame] [2.1] Dialer volume does not respond to changes in volume.
drs
- Admin:
- Nothing new.
- Next steps:
- bug 1060725 - Audit test coverage of ICE contacts
- Going to work on this today.
- Will take more tech debt bugs.
- bug 1060725 - Audit test coverage of ICE contacts
- Done:
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
- Closed, it just wasn't uplifted.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Review- for Paco.
- bug 1041879 - Remove dead 'useNewStyle' code from shared/js/lockscreen_slide.js
- Review- for John. I got into a bit of a discussion over this. See my notes on comment on bug 950884.
- bug 950884 - [VsD Refresh] Lockscreen Visual Refresh
- This bug was a disaster and I made a long post explaining everything I thought went poorly. I'm not happy with anyone's response so I'll be discussing this more.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Waiting for Francisco to review.
- bug 1040922 - Refactor SimPicker such that it triggers MutationObserver on updates
- Waiting for Anthony to review.
- bug 1037868 - Create gaia-sim-picker component
- Patch posted for Anthony to review. Mostly a rebase.
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
Rik
- bug 1060723 is almost there. Need to write new tests for call_log_db.
- Will look at my reviews/feedbacks after I post a patch for this.
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- I have a WIP for feedback
- Finished a set of tests and updated the PR with this.
- Working on a gecko bug in the meantime
jpruden92
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
- Tested on ICE contacts and changed solution. Waiting to review.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- Changing the solution.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Patch made. Waiting to review.
- Improving the solution. Modifying tests.
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
davidg
- Absent/no report
Day 4: September 5
Blockers
- [1.4?] bug 1063407 - There is no ussd result shows when make a ussd request from STK.
- Looks like Gabriele and Anthony are already on this.
- [1.4?] bug 1063407 - There is no ussd result shows when make a ussd request from STK.
drs
- Admin:
- Nothing new.
- Next steps:
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
- Reopened. I'll investigate today.
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- Need to review this for Paco.
- bug 1041879 - Remove dead 'useNewStyle' code from shared/js/lockscreen_slide.js
- Need to review this for John. I stole this from Germán as he's not a dialer peer and he's on PTO.
- bug 1060725 - Audit test coverage of ICE contacts
- Going to work on this today.
- bug 1037868 - Create gaia-sim-picker component
- Will rebase this today so Anthony can review next week.
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
- Done:
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Posted a patch for Francisco to review. There are still some discussions with l10n people going on.
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Review+ for David and landed.
- bug 1061473 - [Flame][Dual SIM] Outgoing call from bluetooth car kit asked which SIM card to use
- Landed.
- bug 1062294 - Bluetooth commands that require SIM picker should show the Dialer app
- Landed.
- bug 1040922 - Refactor SimPicker such that it triggers MutationObserver on updates
- Posted a patch for Anthony to review.
- bug 1054818 - [Sora][Call][Settings]The call time display abnormal after user change the system time.
- Provided a detailed plan for whoever takes it.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- I have a WIP for feedback and am working on tests today.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
davidg
- Absent/no report
Day 3: September 4
drs
- Admin:
- Nothing new.
- Next steps:
- Have to put up my demos.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Going to work on this.
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Need to review this for David.
- Done:
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
- Landed.
- bug 1061473 - [Flame][Dual SIM] Outgoing call from bluetooth car kit asked which SIM card to use
- Patch posted for Anthony to review.
- bug 1062294 - Bluetooth commands that require SIM picker should show the Dialer app
- Patch posted for Anthony to review.
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
Rik
- Reproduced bug 1061616 twice. Given the logcat output, it could be another case of bug 1061510
- Went through a bunch of watched bugs to close them or ask more information
- Reviews:
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Landed
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Setting issue resolved(flash tool fixed it)
- Trying for a WIP today on this one.
- <drs> Let me or Anthony know if you need any help. The SIM picker code can be a bit wonky at times.
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
davidg
- Absent/no report
Day 2: September 3
drs
- Admin:
- We have a new blocker nominations section on the wiki: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Blocker_Nominations
- Next steps:
- Have to put up my demos.
- bug 1059087 - [Contacts] No space between 'Carrier Name' and 'Label'
- Going to post a patch for this.
- bug 1037868 - Create gaia-sim-picker component
- Going to rebase this.
- <Rik> I was thinking of trying to review this next week after the blocker/feature dust settles a bit
- Sure, I'll hold off on rebasing then.
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Need to review this for David.
- Done:
- Sprint planning wiki pages, cleanup, some of the action items.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Review- for Jorge, wrote out an alternative implementation.
- bug 1061149 - [Calllog][Dialer] Phone number is showed with different color in incoming/out/missed calls (in "Call info" screen)
- Posted a patch.
Rik
- bug 1061616 is not easy to reproduce, even for QA. It looks like it may not even be an issue on our side. Will try to reproduce more. I also tried to look for current blockers to see if something else rings a bell for the root cause.
- bluetooth bugs: bug 1061473 and bug 1062294. Seems easy to fix if anyone has bandwith.
- <drs> Yeah, I can take more bugs.
- Gave some ideas to move bug 911055 forward
- And meetings too.
- Reviews:
thills
- bug 1061463 - Call log info must not reuse the string "Missed"
- Have a patch for review
- bug 1060729 - Handle default outgoing call SIM set to "always ask" in ICE contacts
- Having some build issues on my flame (could not get settings to set the lockscreen).
- Rebuilding everything on my flames to see if this resolves the issue. If not, I may file a bug.
- <drs> What's the issue? Want to talk about it after the standup? Yes, I have a screenshot of what the settings page looks like for lockscreen.
- <drs> If we can't fix it or figure out what it is, you can rebase on top of an earlier Gaia commit.
davidg
- bug 911055 - [Dialer]DuT doesn allow to dial a <<pause>>
- On hold. It needs some work on the RIL, but not decided yet exactly how or who is going to do it
- bug 1061120 - [Calllog][Dialer] Time duration format is not showing 'min' or 's' in 'Call Information'
- Pending review from drs
// Part-time people (not required to update this)
gtorodelvalle
- Absent/no report
pacorampas
- Absent/no report
jpruden92
- Absent/no report
Day 1: September 2
drs
- Admin:
- Was on public holiday, Labour Day.
- Did some sprint pre-planning and getting bugs actionable.
pacorampas
- bug 977588 - [Dialer] The Active call screen does not have the option to place calls on hold.
- I am waiting for review.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- The patch works fine but in this bug is needed a feedback of pabratowski@mozilla.com and/or kyee@mozilla.com. I don't know if we can do anything for get the feedback early or what to do.
- bug 933596 - [Dialer] Unable to switch call waiting calls when dial pad is opened.
- I have done a proposal for this bug. I think Carrie isn't happy with my proposal. But, there isn't another suggestion. I am waiting for a NI that I have asked to Rik
thills
- On public holiday, Labor Day.
jpruden92
- <drs> Jorge, it's great that you're working on and learning many components, but please add only things within the dialer that you're working on. It helps us stay focused in here.
- <jpruden92> Hello <drs>, sorry I thought that I had to put all here. Thanks for the info!
- bug 943389 - [Dialer][Conference call] Detailed contact info on conference call on group line is missing:
- <gtorodelvalle> feedback+.
- Waiting to review.
- bug 1030631 - [Dialer] Text not aligned when matches are more than 1 if contact has long name:
- Patch made. Waiting to review.
- bug 1029313 - [Dialer][DSDS] With 2 SIMs; The matching result disappears after typing in the last correct digit when dialing
- Patch made. Waiting to review.
- bug 1038846 - [Dialer] Once you get a contact suggestion, tapping on it even when empty triggers an "Invalid Number" message
- Patch made. Waiting to review.
Rik
- Absent/no report
gtorodelvalle
- Absent/no report
PTO
- davidg: none
- drs: none
- gsvelto: none
- gtorodelvalle: Sep 2 - Sep 15
- jpruden92: ?
- paco: ?
- Rik: Sep 11 - Sep 15
- thills: none
Retrospective
Things we did well
- <thills> the hosting the standup instructions were very good. The velocity calc rocks and makes it much easier. I think we should add a link to the "hosting the standup" instructions on the main page.
- <drs> I'm glad you found it helpful! I've added this.
- <drs> The push at the end of this sprint was heroic! Great job, everyone. We shouldn't have to do that, but we handled a bad situation well.
- <Rik> How can we recreate the emulation we saw on a more regular basis?
- <drs> After discussion: Anthony was referring to the "whole being greater than the sum of its parts" when he said emulation. We discussed having office hours on Vidyo.
- <drs> Gabriele added some docs to the wiki and has been pushing for bug 1031175 to be done properly.
- <gsvelto> I've managed to get the RIL team to post a proper proposal for the MMI refactoring on dev-webapi and it looks much better than the merry-go-round we did on the bug.
- <Rik> We look ok with high res images. Just as a reminder, flash with GAIA_DEV_PIXELS_PER_PX=1.5. And testing locales: https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Test_localizability (the accented english is pretty nice for this)
- <Rik> Spreading the technical lead between Doug, Gabriele and Rik. I felt like I had less bugs to follow.
- <drs> Agreed!
- <davidg> Holidays were great! Sorry guys
- <drs> Nothing to be sorry about, get your rest/relaxation.
- <drs> We have really good data now on how many points of velocity we can reliably burndown every sprint. So far, it's been about 25. We can now use this as a benchmark to see if we're taking too much or too little.
Things we could do better
- <drs> The dialer-most-wanted bug has blown up a bit. Should we switch to a whiteboard tag?
- <gsvelto> I like having the bug, it works better for me but that's just personal preference. Anyway if it's becoming too large and something is not really wanted we could always remove it.
- <drs> After discussion: We decided to stick with the bug. Gabriele also mentioned that it helps to draw attention to how much tech debt we have.
- <drs> We could have done a better job balancing our work in other sprints. We underestimated the amount of work and left too much of it to the end.
- <drs> The Friday deadline for 2.1 features came out of nowhere and pushed us really hard. I follow the release schedule pretty closely and it was never mentioned anywhere until Wednesday. I've already talked with David about this, and I'm going to spend more time with him discussing it soon.
- <davidg> I'm mostly working on certifications waivers, a lot of times I get sidetracked by non dialer stuff. Not sure how to account for that time.
- <drs> After discussion: We assign dialer-most-wanted and nice-to-have bugs to people who are uncertain as to how much time they have.
Action items
- <drs> Added "Hosting the Standup" instructions to the main dialer page: https://wiki.mozilla.org/FirefoxOS/Comms/Dialer#Hosting_the_Standup
- <Rik> Add a query to the blocker nominations (2.1?) to be even more reactive.
- <gsvelto> One of the things that occurred to me during the sprint is that the Telephony/MobileConnection documentation on MDN is horribly outdated and incomplete. I intend to improve it and help is welcome obviously.
- <Rik> Add |GAIA_DEFAULT_LOCALE=qps-ploc make| to the wiki documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_best_practices#Test_localizability
- <Rik> Talk with Contacts team about their mix of Sprints and Kanban.
- <Rik> Send an invite for 1-hour "office hour" over Vidyo every wednesday after the daily standup.
- <Rik> Blog about our 2.1 features (comms, not only dialer).
