Firefox OS/Comms/Dialer/Sprint/v2.1-S9

From MozillaWiki
< Firefox OS‎ | Comms‎ | Dialer‎ | Sprint
Jump to: navigation, search


Bugs Taken in Planning

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1024341 Tamara Hills [:thills] (meta) Wake up the device after a call hangs up --- No cf_feature-b2g torch [planned-sprint][in-sprint=v2.1-S7] RESOLVED FIXED
1068093 Tamara Hills [:thills] Remove legacy transition code from the callscreen --- No cf_feature-b2g [planned-sprint c=1] RESOLVED FIXED
1094746 Paco Rampas [:paco] [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay --- No cf_feature-b2g [planned-sprint c=1] VERIFIED FIXED
1095503 Doug Sherk (:drs) (inactive) Dialer tones are not sent to others during conference call 2.1+ No cf_feature-b2g [planned-sprint c=1] RESOLVED INVALID
1095579 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after merging the call in a conference 2.2+ No cf_feature-b2g [planned-sprint c=3] RESOLVED DUPLICATE
1095601 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after the participant on hold hangs up. 2.2+ No cf_feature-b2g [planned-sprint c=3] RESOLVED DUPLICATE

6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);

Bugs Taken but not Completed

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1092290 Germán Toro del Valle (:gtorodelvalle) [Dialer] Callscreen overlaps conference call screen --- No cf_feature-b2g [2.1-exploratory-3][planned-sprint c=1][in-sprint=v2.1-S9] RESOLVED WONTFIX

1 Total; 0 Open (0%); 1 Resolved (100%); 0 Verified (0%);


Bugs Taken During Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature-b2g Whiteboard Status Resolution
1092362 Gabriele Svelto [:gsvelto] Make the dialer use the `notification' channel for playing the touch tones 2.2+ No cf_feature-b2g RESOLVED FIXED
1094781 Paco Rampas [:paco] [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588) --- No cf_feature-b2g VERIFIED FIXED

2 Total; 0 Open (0%); 1 Resolved (50%); 1 Verified (50%);


All Issues for this Sprint

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
1024341 Tamara Hills [:thills] (meta) Wake up the device after a call hangs up --- --- torch [planned-sprint][in-sprint=v2.1-S7] RESOLVED FIXED
1068093 Tamara Hills [:thills] Remove legacy transition code from the callscreen --- --- [planned-sprint c=1] RESOLVED FIXED
1092362 Gabriele Svelto [:gsvelto] Make the dialer use the `notification' channel for playing the touch tones 2.2+ --- RESOLVED FIXED
1094746 Paco Rampas [:paco] [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay --- --- [planned-sprint c=1] VERIFIED FIXED
1094781 Paco Rampas [:paco] [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588) --- --- VERIFIED FIXED
1095503 Doug Sherk (:drs) (inactive) Dialer tones are not sent to others during conference call 2.1+ --- [planned-sprint c=1] RESOLVED INVALID
1095579 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after merging the call in a conference 2.2+ --- [planned-sprint c=3] RESOLVED DUPLICATE
1095601 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after the participant on hold hangs up. 2.2+ --- [planned-sprint c=3] RESOLVED DUPLICATE

8 Total; 0 Open (0%); 6 Resolved (75%); 2 Verified (25%);

Bugs Redirected

Full Query
ID Assigned to Summary Blocking b2g Feature b2g Whiteboard Status Resolution
1024341 Tamara Hills [:thills] (meta) Wake up the device after a call hangs up --- --- torch [planned-sprint][in-sprint=v2.1-S7] RESOLVED FIXED
1068093 Tamara Hills [:thills] Remove legacy transition code from the callscreen --- --- [planned-sprint c=1] RESOLVED FIXED
1094746 Paco Rampas [:paco] [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay --- --- [planned-sprint c=1] VERIFIED FIXED
1095503 Doug Sherk (:drs) (inactive) Dialer tones are not sent to others during conference call 2.1+ --- [planned-sprint c=1] RESOLVED INVALID
1095579 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after merging the call in a conference 2.2+ --- [planned-sprint c=3] RESOLVED DUPLICATE
1095601 Germán Toro del Valle (:gtorodelvalle) On hold button says call is held after the participant on hold hangs up. 2.2+ --- [planned-sprint c=3] RESOLVED DUPLICATE

6 Total; 0 Open (0%); 5 Resolved (83.33%); 1 Verified (16.67%);


Daily Standup Meetings

  • Current hosts: drs, gtorodelvalle, thills
  • Hosts rotate every week.
  1. If you're not available for a standup that you're scheduled to host, then ask for someone else to host instead for just that time.
  2. Start by pinging everyone who should be participating.
  3. List any administrative items you have, and then ask for more from other people (look at the Etherpad).
  4. Look at the list of blockers and blocker nominations and see if there's anything new or that needs action. Mention these during this time.
  5. Move to individual updates. Go alphabetically, in descending order.
  6. If someone's update is taking longer than 3-4 minutes, you should generally cut them off and ask them to talk about it after the standup.
  7. Copy the reports from the GDoc to the wiki page for that day. Use the Etherpad-to-Wiki converter to format it. You can just copy and paste the whole thing and the converter will do everything for you.
  8. Ask the person who should be hosting the week after you if they'll be available. If not, move onto the next person.

Day 10: Nov 24

FirefoxOS/Comms/Dialer/Sprint/v2.1-S9/20141124-StandupNotes

Day 9: Nov 21

drs

  • On PTO today.
  • Did sprint pre-planning.
  • Filed RTL bugs.

gtorodelvalle

  • Admin:
    • It is not clear when Paco will be joining the Loop (Firefox Hello) team in Telefónica :( For the time being we can continue counting on him but I would not include him in our planifications of future work.
    • I have been invited to a round table about the Open Web at the university on Monday at 16:00. I’ll talk about Firefox OS as a success story :)
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • Final review by Doug ready to be done and discussed by IRC.
      • r+.
      • Squashing commits and waiting on the tests to pass.
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • First patch pushed to Github.
      • r? to Doug.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I found an scenario which requires further thinking by Carrie. I need-infoed her about it ;)
      • I have to think about the solution proposed by Carrie.
    • bug 1098455 - [Dialer][Call Screen] Mute and speaker buttons are not enabled in call waiting if first call was held:
      • I have a patch available but I’ll wait until the one for bug 1094878 lands to send the pull request to have everything under control.
  • Reviews:

thills

  • Admin Nothing
    • bug 1078448 - Found a broken test in this. Reposted and got re-review. Will land this today.
    • bug 1066874 - Need to work on a repro for this one with the timestamps.
    • bug 976990: f+ on this. Spent some time retesting the different matching scenarios on this. Requested some review from Etienne on this.
    • bug 1093364: This was resolved as closed WFM. No longer working on this.
    • bug 1069499: Working on this review for peterp today.

jlorenzo

  • Admin:
  • Next steps:
    • bug 1083731: pending feedback from QA in the US to run the test with AT&T and T-Mobile.
    • MarionetteJS intermittently runs on device now. See https://bugzilla.mozilla.org/show_bug.cgi?id=1099363
    • This test is really intermittent since a couple of days, I’ll try to investigate that one. bug 1098107 - Intermittent test_dialer_add_contact.py TestDialerAddContact.test_dialer_add_contact | TimeoutException: TimeoutException: Timed out after 10.1 seconds
  • Waiting for review
    • bug 1093583 - [DSDS] Add test to make a phone call with default SIM.

Paco

    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • Merged
    • bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call
      • R+ waiting for tests
      • Upload demo shot
      • bug 1063032 - [Active Call] Visual Refinements for attention window
    • Redirct to German.
      • bug 1079794 - [Dialer] [Callscreen] When you are in active call and other call is entering you can't hold and answer with headset button
    • I am working on it. Monday I will have more info. but there is a problem with tests.
  • Other:
    • I am working in a bug of other app.

gsvelto

  • Absent/no report

Day 8: Nov 20

FirefoxOS/Comms/Dialer/Sprint/v2.1-S9/20141120-StandupNotes

Day 7: Nov 19

drs

  • Admin:
    • Taking tomorrow off.
  • Next steps:
    • Creating bugs for 2.2 features and planning our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
    • Will look at Dialer in RTL mode and file bugs.
  • Patches:
    • Nothing new.
  • Reviews:
    • bug 1094896 - [Dialer] Hash key still highlighted after calling MMI Code *#06#
      • r+
    • bug 1078448 - Callscreen app instances linger in bfcache after being closed
      • r+
    • bug 1069499 - [Dialer] [User Story] It should be possible to easily delete single entry from the call log list
      • r?
  • Other:
    • Nothing new.

thills

  • Admin Nothing
    • bug 1078448 - Posted review for this. Will fix the nits on this.
    • bug 1066874 - Need to work on a repro for this one with the timestamps.
    • bug 976990: f+ on this. Spent some time retesting the different matching scenarios on this. Requested some review from Etienne on this.
    • bug 1093364: Tried reproing this last night and was not able to on latest build with the complex set of steps. I was able to repro on earlier build. I’m asking for someone else to try, and then I will look to see if perhaps the call screen transitions could have affected this bug and inadvertently fixed it.

gtorodelvalle

  • Absent/no report

jlorenzo

  • Absent/no report

gsvelto

  • Absent/no report

Paco

  • Absent/no report

Day 6: Nov 18

Blockers

  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Landed, but not uplifted yet.
    • Didn’t get approval for v2.0 or v2.1. Needs to be fixed in bug 1092362 first.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1092362 - Make the dialer use the `notification' channel for playing the touch tones
    • Assigned to Gabriele.
    • Patch posted, workaround.
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
    • New patch coming :)
  • 2.2? bug 861754 - [Buri][Shira-48161][USSD]Terminal behavior when more then one USSD message was sent to terminal
    • Unassigned.
  • 2.2? bug 1100277 - [Midori 2.0][Call]The add a call is still mute when the first call is mute
    • Unassigned.

drs

  • Admin:
    • I will only be able to make it to the first half-hour of the office hour tomorrow.
  • Next steps:
    • Creating bugs for 2.2 features and planning our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
    • Will look at Dialer in RTL mode and file bugs.
  • Patches:
    • Nothing new.
  • Reviews:
    • bug 1096234 - Relax the checks for CDMA call-waiting to ensure stable operation while switching calls
      • r-, new r?
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • r-, new r?
    • bug 1092362 - Make the dialer use the `notification' channel for playing the touch tones
      • r?
    • bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
      • f?
  • Other:
    • Nothing new.

gtorodelvalle

  • Admin:
    • I have to check Paco’s availability since “I have heard” that the Loop team in Telefónica has requested him to join them. I’ll share any info with you tomorrow.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • Working on a new patch linking the ‘is held by the user’ state to each affected call.
      • Updating the test cases.
      • Some refactoring included.
      • r? to Doug.
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Paco is currently working on it.
      • Giving a hand to Paco on this.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I found an scenario which requires further thinking by Carrie. I need-infoed her about it ;)
    • bug 1098455 - [Dialer][Call Screen] Mute and speaker buttons are not enabled in call waiting if first call was held:
      • I have a patch available but I’ll wait until the one for bug 1094878 lands to send the pull request to have everything under control.
  • Reviews:
    • I’ll track that Paco includes demos for the recent bugs I set the r+ to and which have been already merged.

thills

  • Admin Nothing
    • bug 1078448 - Posted review for this. Revisiting these tests today while on bug 976990 feedbacks.
    • bug 1066874 - Need to work on a repro for this one with the timestamps.
    • bug 976990: f- on this. Put a patch for feedback last night on this.

jlorenzo

  • Admin:
    • Contacts WW in Paris
  • Next steps:

gsvelto

  • Admin:
    • Nothing to report
  • Next steps:
    • bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
      • Landed, now trying to uplift to 2.1 and 2.0
      • Uplifted patch for 2.1 ready for approval, working on one for 2.0 too
      • Both the uplifted patch for 2.1 and 2.0 were finished and tested and they’re both waiting for approval
      • Both patches weren’t accepted due to bug 1092362, waiting to fix that before asking for approval again
    • bug 1031175 - [Gaia] Unify both sendMMI() and dial() functions
      • The gecko part landed and stuck but we’re still missing a piece! Waiting for bug 1080883 to land before touching this.

but it allowed us to discover that we were missing this piece of functionality in the RIL so that’s a positive outcome nevertheless

      • <drs> bug 1080883 landed, so I think we can get back to this now.
  • Patches:
    • bug 1096234 - Relax the checks for CDMA call-waiting to ensure stable operation while switching calls
      • Fourth iteration, waiting for review
    • bug 1092362 - Make the dialer use the `notification' channel for playing the touch tones
      • Prepared a workaround that while not fixing the underlying issue solves all visible problems, when uplifting bug 834530 we should include it
    • bug 1094896 - [Dialer] Hash key still highlighted after calling MMI Code *#06#
      • Prepared a patch that fixes the issue both in the dialer and in the emergency call app, it should also improve the user experience when quickly tapping the keys by making the highlight more responsive
  • Reviews:
    • Nothing to report
  • Other:
    • Nothing to report

Paco

    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • Wainting for green tests
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • I have uploaded a demo screenshot on wiki
    • bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call
      • R+ waiting for tests
      • I should upload a demo shot.
      • bug 1063032 - [Active Call] Visual Refinements for attention window
    • Yesterday and today i am working on this and is advanced. I am ask for feedback to German.

Day 5: Nov 17

Blockers

  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Landed, but not uplifted yet.
    • Didn’t get approval for v2.0 or v2.1. Needs to be fixed in bug 1092362 first.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1092362 - Make the dialer use the `notification' channel for playing the touch tones
    • Unassigned.
    • Fixes a lot of really bad issues.
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
    • New patch coming :)
  • 2.0? bug 861754 - [Buri][Shira-48161][USSD]Terminal behavior when more then one USSD message was sent to terminal
    • Unassigned.
    • Devices team should take this.

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • Creating bugs for 2.2 features and planning our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
    • Will look at Dialer in RTL mode and file bugs.
  • Patches:
    • bug 1095503 - Dialer tones are not sent to others during conference call
      • Investigated, closed as this is standard carrier behavior.
  • Reviews:
    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • r+
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • r-
  • Other:
    • Nothing new.

gtorodelvalle

  • Admin:
    • Nothing to mention.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • Working on a new patch linking the ‘is held by the user’ state to each affected call.
      • Updating the test cases.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I found an scenario which requires further thinking by Carrie. I need-infoed her about it ;)
    • bug 1098455 - [Dialer][Call Screen] Mute and speaker buttons are not enabled in call waiting if first call was held:
      • I have a patch available but I’ll wait until the one for bug 1094878 lands to send the pull request to have everything under control.
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Paco is currently working on it.
  • Reviews:
    • I’ll track that Paco includes demos for the recent bugs I set the r+ to and which have been already merged.

thills

  • Admin Nothing
    • bug 1078448 - Posted review for this. Got an r-. Need to change the tests.
    • bug 1066874 - Need to work on a repro for this one with the timestamps.
    • bug 976990: f- on this. I believe I have a patch that fixes this issue. I’m still testing and will try to have a feedback done for end of day today.

jlorenzo

  • Absent/no report

gsvelto

  • Absent/no report

Paco

  • Absent/no report

Day 4: Nov 14

Blockers

  • 2.1+ bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • Assigned to Doug.
    • Landed.
  • 2.1+ bug 1095503 - Dialer tones are not sent to others during conference call
    • Assigned to Gabriele.
    • Doug investigated, seems to be a RIL issue.
  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Waiting for approval for v2.0 and v2.1.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
    • New patch available and revision requested from Doug. I think this is it ;)
    • r?
  • 2.2+ bug 1095579 - On hold button says call is held after merging the call in a conference
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
    • DUPLICATE of bug 1094878. The patch proposed for this other bug solves the issue.
  • 2.2+ bug 1095601 - On hold button says call is held after the participant on hold hangs up.
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
    • DUPLICATE of bug 1094878. The patch proposed for this other bug solves the issue.
  • 2.0M? bug 1096743 - [FFOS2.0][Woodduck][Call]phone does not vibrate when receive a call.
    • Unassigned.
    • Devices team should take this.

drs

  • Admin:
    • A new version of the tabless redesign spec is posted.
  • Next steps:
    • Creating bugs for 2.2 features and planning our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
  • Patches:
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
      • Landed.
    • bug 1095503 - Dialer tones are not sent to others during conference call
      • Investigated, seems to be a RIL issue.
  • Reviews:
    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • r-, new r?
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • r-, new r?
  • Other:
    • Nothing new.

gtorodelvalle

  • Admin:
    • Nothing to mention.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • New patch available and revision requested from Doug. I think this is it ;)
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I found an scenario which requires further thinking by Carrie. I need-infoed her about it ;)
    • bug 1098455 - [Dialer][Call Screen] Mute and speaker buttons are not enabled in call waiting if first call was held:
      • I have a patch available but I’ll wait until the one for bug 1094878 lands to send the pull request to have everything under control.
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Paco is currently working on it.
  • Reviews:
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • r+
    • bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay
      • Ready for r+ but I wanted to clarify with Olle Klang before this why /shared/style/dialer/overlay.css is linked by the default_theme app.
      • After Olle’s reponse, r+ and we are ready to merge ;)
    • bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call:
      • r+

thills

jlorenzo

  • Absent/no report

gsvelto

  • Absent/no report

Paco

  • Absent/no report

Day 3: Nov 13

Blockers

  • 2.1+ bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • Assigned to Doug.
    • Landed.
  • 2.1+ bug 1095503 - Dialer tones are not sent to others during conference call
    • Assigned to Gabriele.
  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Waiting for approval for v2.0 and v2.1.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095579 - On hold button says call is held after merging the call in a conference
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095601 - On hold button says call is held after the participant on hold hangs up.
    • Assigned to Germán.
    • Regression/incomplete from bug 977588.
  • 2.0M? bug 1096743 - [FFOS2.0][Woodduck][Call]phone does not vibrate when receive a call.
    • Unassigned.
    • Devices team should take this.

drs

  • Admin:
    • The call metrics stuff will not be part of our committed work for 2.2. Marshall will be taking it.
  • Next steps:
    • Dealing with Dialer requirements for 2.2 with product and UX.
    • Going to create bugs for 2.2 features and plan our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
  • Patches:
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
      • Patch posted, waiting for Germán and Tamara to review. Waiting for Etienne to give feedback.
  • Reviews:
    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • r-
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • r-
  • Other:
    • Nothing new.

gtorodelvalle

  • Admin:
    • Nothing to mention.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • I included a comment for Doug about the best approach to solve the issue. We can talk about it after the standup meeting via IRC.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • Patch available. Currently testing it. I’ll ask for a review from Doug in a sec.
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Paco is currently working on it.
  • Reviews:
    • bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay
      • Ready for r+ but I wanted to clarify with Olle Klang before this why /shared/style/dialer/overlay.css is linked by the default_theme app.
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • r-
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • r+ with a comment

thills

jlorenzo

  • Admin:
    • MarionetteJS doesn’t work on device (it freezes up the phone)
  • Next steps:
    • I verified bug 998147 and I’m currently on bug 834530
    • bug 1083731: pending feedback from QA in the US to run the test with AT&T and T-Mobile.
    • Starting to automate some DSDS bugs for the next 2 weeks
      • Tests are working on my local device. Stuck at setting up Jenkins. See 1093583

gsvelto

  • Absent/no report

Paco

  • Absent/no report

Day 2: Nov 12

Blockers

  • 2.1+ bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • Assigned to Doug.
    • Patch posted, waiting for Germán and Tamara to review. Waiting for Etienne to give feedback.
  • 2.1+ bug 1095503 - Dialer tones are not sent to others during conference call
    • Assigned to Gabriele.
  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Waiting for approval for v2.0 and v2.1.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095579 - On hold button says call is held after merging the call in a conference
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095601 - On hold button says call is held after the participant on hold hangs up.
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.0M+ bug 1092962 - [FFOS2.0][Woodduck][Voicemail]There is any prompt message when dial the voicemail number by long press the "1" key.
    • Assigned to Gary Chen of the devices team.
    • Landed.
  • 2.0M? bug 1096743 - [FFOS2.0][Woodduck][Call]phone does not vibrate when receive a call.
    • Unassigned.
    • Devices team should take this.

drs

  • Admin:
    • Nothing new.
  • Next steps:
    • Dealing with Dialer requirements for 2.2 with product and UX.
    • Going to create bugs for 2.2 features and plan our work timeline.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
  • Patches:
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
      • Patch posted, waiting for Germán and Tamara to review. Waiting for Etienne to give feedback.
  • Reviews:
    • bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay
      • Redirected to Germán.
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • Redirected to Germán.
    • bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call
      • Redirected to Germán.
    • bug 1092962 - [FFOS2.0][Woodduck][Voicemail]There is any prompt message when dial the voicemail number by long press the "1" key.
      • r+
    • bug 1069836 - [Dialer][Call Screen] Improve the localizantion of call options in call screen (follow up of 977588)
      • r?
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • r?
  • Other:
    • Nothing new.

gtorodelvalle

  • Admin:
    • I have just been told that it seems that there will finally be some people invited to the next working week in Portland from selected partners :p Kidding! And it seems my name is on the table :) Let’s see if it finally gets confirmed ;) BTW, I was also told that Doug’s interest (and also myself, of course) helped a lot.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • Patch available. Review requested from Doug and feedback requested from Johan since it was involved in the discussion and in fact reported the bug ;)
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Implementing the new appearance of the minimized call screen as specified at https://mozilla.app.box.com/s/b6vzr85snxplv32rpkwu
      • Having issues using the WebIDE with recent builds (the apps are not shown in the list) as well as establishing outgoing calls (a white page is shown to the user and the battery has to be pulled out).
        • <drs> You can use |DEVICE_DEBUG=1 NOFTU=1 make reset-gaia| to fix this, I believe. WebIDE works fine for me.
        • Thanks! I’ll try it ;)
      • Investigating the issue because I am kind of stuck due to it.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I requested some feedback from Carrie regarding the best approach to solve the issue.
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • Checking Paco’s patch proposal.
      • I requested info from Carrie to try to provide the final user with an uniform and user-friendly :) approach to all the call-holding related scenarios.
  • Reviews:
    • bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay
      • Ready for r+ but I wanted to clarify with Olle Klang before this why /shared/style/dialer/overlay.css
is linked by the default_theme app.
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • r-
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • Review in progress… :p

thills

jlorenzo

  • Admin:
    • I’ll be in the SmartData kick off for the 1st half hour of the office hour
  • Next steps:

gsvelto

  • Absent/no report

Paco

  • Absent/no report

Day 1: Nov 11

Blockers

  • 2.1+ bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    • Assigned to Doug.
  • - but still important bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    • Assigned to Gabriele.
    • Waiting for approval for v2.0 and v2.1.
  • partner-blocker bug 976990 - [Sora][Call Log] Contact's name still display in call log after delete the contact from phonebook.
    • Assigned to Tamara.
  • 2.2+ bug 1093364 - [Dialer] Call screen does not display call info and shows a black background
    • Assigned to Tamara.
  • 2.2+ bug 1095503 - Dialer tones are not sent to others during conference call
    • Assigned to Gabriele
  • 2.2+ bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095579 - On hold button says call is held after merging the call in a conference
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.2+ bug 1095601 - On hold button says call is held after the participant on hold hangs up.
    • Assigned to Paco.
    • Regression/incomplete from bug 977588.
  • 2.0M+ bug 1092962 - [FFOS2.0][Woodduck][Voicemail]There is any prompt message when dial the voicemail number by long press the "1" key.
    • Assigned to Gary Chen of the devices team.
    • Has a r+’d patch ready to land.
  • 2.0M? bug 1096743 - [FFOS2.0][Woodduck][Call]phone does not vibrate when receive a call.
    • Unassigned.
    • Devices team should take this.

drs

  • Admin:
    • Reviewers, remember to ask for demos.
    • Bidi scoping meeting later today. 12 pm EST, 6 pm CEST.
  • Next steps:
    • Dealing with Dialer requirements for 2.2 with product and UX.
    • bug 1046090 - Explore if we can split Dialer and Contacts
      • Going to work on this.
    • bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
      • Going to work on this.
  • Patches:
    • Nothing new.
  • Reviews:
    • bug 1096234 - Relax the checks for CDMA call-waiting to ensure stable operation while switching calls
      • r-
    • bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay
      • Redirected to Germán.
    • bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)
      • Redirected to Germán.
    • bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call
      • Redirected to Germán.
    • bug 1092962 - [FFOS2.0][Woodduck][Voicemail]There is any prompt message when dial the voicemail number by long press the "1" key.
      • r?
  • Other:

gtorodelvalle

  • Admin:
    • Nothing to report.
  • Next steps:
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
      • First implementation including Carrie’s comments available.
      • I have to check with her some call holding scenarios (such as establishing conference calls, holding them, adding new calls and so on).
    • bug 1063032 - [Active Call] Visual Refinements for attention window:
      • Implementing the new appearance of the minimized call screen as specified at https://mozilla.app.box.com/s/b6vzr85snxplv32rpkwu
      • Having issues using the WebIDE with recent builds (the apps are not shown in the list) as well as establishing outgoing calls (a white page is shown to the user and the battery has to be pulled out).
        • <drs> You can use |DEVICE_DEBUG=1 NOFTU=1 make reset-gaia| to fix this, I believe. WebIDE works fine for me.
        • Thanks! I’ll try it ;)
      • Investigating the issue because I am kind of stuck due to it.
    • bug 1092290 - [Dialer] Callscreen overlaps conference call screen:
      • I requested some feedback from Carrie regarding the best approach to solve the issue.
    • bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is:
      • Checking Paco’s patch proposal.
      • I requested info from Carrie to try to provide the final user with an uniform and user-friendly :) approach to all the call-holding related scenarios.
  • Reviews:

thills

gsvelto

  • Admin:
    • Nothing to report
  • Next steps:
    • bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
      • Landed, now trying to uplift to 2.1 and 2.0
      • Uplifted patch for 2.1 ready for approval, working on one for 2.0 too
      • Both the uplifted patch for 2.1 and 2.0 were finished and tested and they’re both waiting for approval
    • bug 1031175 - [Gaia] Unify both sendMMI() and dial() functions
      • The gecko part landed and stuck but we’re still missing a piece! Waiting for bug 1080883 to land before touching this.

but it allowed us to discover that we were missing this piece of functionality in the RIL so that’s a positive outcome nevertheless

    • bug 1095503 - Dialer tones are not sent to others during conference call
      • Found a SIM-card where this works, will test tomorrow
  • Patches:
    • bug 1096234 - Relax the checks for CDMA call-waiting to ensure stable operation while switching calls
      • Second iteration, waiting for review
  • Reviews:
    • Nothing to report
  • Other:
    • Nothing to report

jlorenzo

  • Absent/no report

Paco

  • Absent/no report

PTO

  • drs: none
  • gsvelto: November 14th, PTO
  • gtorodelvalle: None
  • jlorenzo: November 11th, bank holiday in France
  • paco: ?
  • thills: None for this sprint, but I will be out part of the US Thanksgiving week (following sprints)?

Office Hours

Day 7

Day 2

Retrospective

Retrospective Etherpad

Things we did well

  • <drs> We landed several really large bugs.
    • <gsvelto> And the patches stuck!
  • <drs> We came up with a plan to tackle our 2.2 features.
  • <drs> We killed the bi-weekly meeting.

Things we could do better

  • <thills> I think I messed up in the review/feedback for the airplane mode bug. After giving my review, it should have then gone to drs, but that got bypassed and they landed it... so we should figure out a better step-wise process for German and I to go through since we are doing reviews that sometimes involve other teams so we can avoid the confusion.
  • <gtorodelvalle> Definitely I have to check my agenda before the spring planning meetings to better identify my availability in advance.
  • <gsvelto> Two issues regarding the UI being inconsistent with the actual calls state cropped up last week. We should really spend some time to clean up our UI story.

Action items

  • <drs> I will set review? on myself even if I end up only giving feedback+ at the end of reviews.

Demos

  1. Bug 1094781 - [Dialer][Callscreen] The call on hold shouldn't be red (follow up 977588)]
    1. Onhold-opacity.png
  2. Bug 1094746 - [Dialer][Call Screen] Remove horizontal line at the bottom of a conference participant list overlay]
    1. Conference-line-bottom.png
  3. Bug 1096916 - [Dialer][Callscreen] The direction icon is incorrect when is hanging up a hold call]
    1. Ended-icon-hold.png
  4. Bug 1094878 - Call is not on hold anymore after hanging up another call even though the icon says it is
    1. [Screencast] Second outgoing call hung up after holding the first one
    2. [Screencast] Second incoming call hung up after holding the first one
    3. [Screencast] Toggling calls makes the first held call to be resumed after hanging the second one
    4. [Screencast] Merging calls makes the first held call to be resumed after hanging the second one
  5. bug 1093862 - [Dialer]The dialer app will become unresponsive when the user ends a call, quickly presses the conference call button, and then taps the notifications bar that appears immediately after
    1. [Screencast] Original behavior
    2. [Screencast] New behavior
  6. bug 834530 - Emergency dialer DTMF tones aren't regulated by the volume button (and are different volume from Dialer App's DTMF tones)
    1. [Screencast] Non-working volume control
    2. [Screencast] Fixed volume control
  7. bug 1092362 - Make the dialer use the `notification' channel for playing the touch tones
    1. [Screencast] Music interrupted by touch tones
    2. [Screencast] Music continues playing when using the keypad
Retrieved from "https://wiki.mozilla.org/index.php?title=Firefox_OS/Comms/Dialer/Sprint/v2.1-S9&oldid=1052227"