Confirm
976
edits
Changes
→Guidelines on approval comments
=== Guidelines on approval comments ===
* [Bug caused by] (feature/regressing bug #): If you this is a fallout from a feature/bug, or a backout please state the reason along with the bug number
* [User impact] if declined: In addition to the STR reported in the bug if you can explain on a deeper level aspect of how an end user would be impacted with/without your change
* [Testing completed]: What kind of testing was completed here. Manual and/or automated ? Any details about what scenarios the tests cover? If the patch landed on a master/central branch or any other branch did we get verification from reporter or QA.
* [Risk to taking this patch]: No risk/Zero risk are unacceptable here. Even a single line of code change could be damaging!, yes we've seen that** When saying something is "low","medium", "risky" please justify** Eg : Low risk because its a one line css change impacting only settings page** Eg : Medium, given the code complexity and integration with other areas of code that might be impacted. Expect regressions in areas like..** Eg : risky, given the complex nature the bake time we have have on master/central or other branches. High rate of fallouts/regression. Could be mitigated by more manual testing in areas or running some targeted test cases..
* [String changes made]: Please answer this as "none" if no string changes were made
