TPE-Layout/2017-01-10
From MozillaWiki
Contents
Weekly Summary
- [Program] Astley will kick off a survey of time management skills with respect to your daily work.
Weekly Sharing
Astley Chen
Jeremy Chen
CSS Text Module Level 3
Cameron McCormack
- Testing in stylo
Ting-Yu Lin
- Difference between `git rebase -X theirs origin/master` and `git rebase -X ours origin/master`.
Weekly Status
Astley Chen
- bug 1304684 - Every test in w3c-css/submitted/masking/ will fail when Gecko 51 is merged to beta on November 14th
- Patch updated and ready to be integrated to beta 52.
- bug 1328410 - Location Bar should get focus when click the Location Bar even if identity arrow-panel had opened
- STR found and fixed by Gij.
- Q4 and 2016 standing board updated. link
Boris Chiou
Stylo - Animations
- bug 1317209 - Stylo: Interpolate servo animation values using and add to the cascade
- OOAD
- bug 1329878 - Stylo: Implement accumulate and addition on Servo AnimationValue
- file
Cameron McCormack
Stylo
- bug 1315155 - use nsStyleImageRequest in nsStyleContentData
- land
- bug 1328223 - stylo: layout/style/crashtests/498036-1.html crashes due to invalid URL
- r+ | land
- bug 1328546 - stylo: support ServoStyleSheets in nsIStyleSheetService::PreloadSheet and nsIDOMWindowUtils::AddSheet
- r+ | land
- bug 1323706 - stylo: layout/style/crashtests/601437-1.html fatally asserts with "value" under mozilla::dom::binding_detail::DoGetOrCreateDOMReflector<nsMediaList, ...>
- r+ | land
- bug 1290209 - stylo: Set metadata on servo style sheets
- r+ | land
- bug 1323702 - stylo: layout/mathml/crashtests/477740-1.xhtml fatally asserts with "IsGecko()" under nsXULElement::Clone
- r+ | land
- bug 1323665 - stylo: several tests fatally assert with "stylo: unimplemented SetEnabled"
- r+ | land
- servo#14922 - Don't inherit all properties for eagerly computed pseudos if there are no matching rules.
Other
- bug 1328832 - rename mozFlushType to mozilla::FlushType
- r+ | land
Stylo reviews
- bug 851892 - Move CSS Rules to WebIDL
- bug 1323678 - stylo: several tests fatally assert with "NS_IsMainThread() (ServoAttrSnapshots can only be dropped on the main thread)"
- bug 1323655 - stylo: several tests panic with "called `Option::unwrap()` on a `None` value"
- bug 1328765 - [Stylo] Make Talos run on Stylo
- bug 1328786 - Stylo: Store animation properties into nsStyleDisplay::mAnimations
- bug 1328825 - [Stylo] Update reftest-stylo.list and expectations
- bug 1329076 - stylo: Add :-moz-browser-frame pseudo-class for fullscreen
- bug 1328512 - stylo: Run all style system tests which do not crash or timeout
- bug 1328651 - Move servo initialization/shutdown to nsLayoutStatics
Other reviews
- bug 1273807 - mask-position and mask-size animation test case
CJ Ku
- bug 1313757 - background-clip: text does not work well with background-attachment: fixed
- WIP
- bug 1329411 - Containers tab bar visual glitch when hovering over the new tab button
- land
- bug 1329091 - mask-position animation out-of-order
- land
- bug 1273807 - mask-position and mask-size animation test case
- land
- bug 1323912 - Paint opacity into non SVG mask
- land
Farmer Tseng
- bug 1321496 - Convert PDF to EMF in Windows
- f- | wip - refactor patches
- Create a XPCOM interface to show print dialog with print session
- wip - setup IPC connection for print job
Jeremy Chen
CSS Text Module Level 3
- bug 1316482 - Whitespace around the segment break should be removed before segment break transformation
- r+ | land
- bug 1056516 - presence of explicit soft-hyphen in a word should override automatic hyphenation
- OOAD | wip
- bug 1328540 - Convert NS_STYLE_HYPHENS_* to an enum class
- file | land
Shing Lyu
Stylo
- Bug 1328825 - Updated the reftest expectation
- Bug 1289964 - Triage the reftest crashes and failures
- Write the stylo test plan with Chris
- Bug 1328765 - Study Talos on stylo
Servo
- #14685 - Working on display inline-flex
Evangelism
- Rust beginner tutorial for Moz TW community
Tingyu Lin
- bug 1311244 - Implement the rendering of basic shape circle() for CSS shape-outside
- r+
- Backout due to test fails on Win7 debug.
- bug 1320014 - Clean up definition and macros related to mozilla::css::Corner
- land
- bug 1328236 - Add a test for 'shape-outside: border-box' combined with negative margins
- file
Tommy Kuo
- bug 1273244 - Add support for {background|mask}-repeat-{x|y}
- WIP
- bug 1329381 - Computed value of background-repeat should be a list, each item consisting of: two keywords, one per dimension.
- file | WIP
- bug 1229979 - The shadow of decoration line is draw in a different color when the shadow blur is not zero
- debug
Weekly Announcement
Rule of Thumb
Status code:
- OOAD: In analysis or design phase.
- WIP: working on WIP patch.
- feedback(f): feedback a patch
- feedback?(f?): WIP is ready for feedback grant.
- feedback+(f+): Get positive feedback.
- feedback-(f-): Get negative feedback.
- review(r): review a patch.
- review?(r?): patch is under review
- review+(r+): get review+ and ready to check-in
- review-(r-): get negative review feedback. Fix problems and switch back to r? again.
- land: patch check in.
- debug: Figure out the root cause of a bug/ try to repro that bug, etc...
- file: file a bug
- PTO: take personal leave
- interview(I)
- study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
- presentation
- Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
- WIKI/ MDN article writing.
- If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
- Do a presentation of technical topics
Status code combination rule
Combine status code with "|". For example
** OOAD|WIP
Which means you work on both OOAD and WIP in the last week.
land status code
If your patch is target for specific branch, instead of central, postfix branch version. For exp
** land(1.4)
