TPE-Layout/2017-02-07

Weekly Summary

Weekly Announcement

Weekly Sharing

• Astley Chen
  • Form control styling support from CSS4-UI
  • bug 910022 - [e10s] Properly style <option> elements in the parent process UI (support color and background on select options)
• CJ
  • bug 1335876 - transform-box property is affecting SVG positioning attributes
• Shing
  • Beautiful log viewer: lnav
  • easylog

Weekly Status

Astley Chen

Boris Chiou

stylo animations

• bug 1317209 - Stylo: Interpolate servo animation values using and add to the cascade
  • land
• bug 1324691 - stylo: several tests non-fatally assert with "stylo: Servo-backed style system should not be using EffectCompositor" and "stylo: ServoRestyleManager does not support animations yet"
  • land
• bug 1324690 - stylo: several tests non-fatally assert with "stylo: Servo-backed style system should not be using EffectCompositor"
  • land
• bug 1335942 - stylo: Need a way to convert RawServoAnimationValue to layers::Animatable
  • r+
• bug 1334036 - stylo: Support off-main-thread animations
  • file
• bug 1337229 - stylo: Implement the deep operator==() for RawServoAnimationValue
  • file

Animations

• bug 1324554 - Assertion failure: !animationProperty
  • land

Cameron McCormack

Stylo

• bug 1334735 - move mNeedStyleRefresh and mNeedLayoutRefresh flags from nsIDocument to nsIPresShell
  • WIP
• get reftest-stylo jobs green

Other

• bug 1334876
  • r+ | land

Stylo reviews

• bug 1332657 - stylo: Make transform animatable
• bug 1335308 - stylo: Add some assertions to document our invariants and aid the static analysis
• bug 1335317 - stylo: HasFixedPosContainingBlockStyleInternal call during CalcStyleDifference can touch the cached structs

Other reviews

• bug 1302340 - SVG elements and negative tabindex
• bug 1302341 - SVG link element focus behavior

CJ Ku

• bug 1336924 - Add more invalid test cases in property_database for shape-box and transform-box
  • land
• bug 1336905 - Replace StyleShapeOutsideShapeBox by StyleGeometryBox
  • r+
• bug 824300 - "ASSERTION: GetVisualOverflowRect() won't return the pre-effects rect!" with {ib}, CSS filter
  • r?
• bug 1334554 - Handle return value of nsFilterInstance::PaintFilteredFrame
  • r?
• bug 1224207 - Scaling SVG or text with filters should not blur
  • r?
• bug 872483 - reftest text-svgglyphs/svg-glyph-mask.svg fails on all platforms
  • r?

Farmer Tseng

• Porting Mortar to Windows.
• Prepare build environment, build pepperpdfium.dll
• bug 1333660 - Assertion failure: mHasActivePage (We can't guarantee a valid DrawTarget)
  • land
• bug 1333331 - Convert files with DOS line breaks to Unix line breaks
  • land

Jeremy Chen

CSS Text Module Level 3

• bug 1056516 - presence of explicit soft-hyphen in a word should override automatic hyphenation
  • f?
  • add tests into w3c-css repo

Other

• bug 1337009 - Re-enable CSS shapes reftests and CSS text reftests on Windows debug builds
  • file | review

Shing Lyu

Stylo

• Bug 1329919 - Unblocked the tp5o talos test

Servo

• #15149 - Studying flexbox intrinsic aspect ratio bug
• Studying Servo's JS Rooting

Evangelism

• Studying Python VM in Rust

Tingyu Lin

• bug 1334227 - Crash [@ nsFloatManager::FloatInfo::FloatInfo ]
  • land
• bug 1326407 - Implement the rendering of basic shape inset() for CSS shape-outside
  • WIP

Tommy Kuo

• Sick leave
  • Bone fracture
• Study some specifications & bugs
  • Grid Layout Level 1
    • https://bugzilla.mozilla.org/show_bug.cgi?id=616605
    • https://www.w3.org/TR/css-grid-1/
  • Text Module Level 3
    • https://bugzilla.mozilla.org/show_bug.cgi?id=104960
    • https://www.w3.org/TR/css-text-3/
  • Rhythmic Sizing
    • https://drafts.csswg.org/css-rhythm/

Rule of Thumb

Status code:

• OOAD: In analysis or design phase.
• WIP: working on WIP patch.
• feedback(f): feedback a patch
• feedback?(f?): WIP is ready for feedback grant.
• feedback+(f+): Get positive feedback.
• feedback-(f-): Get negative feedback.
• review(r): review a patch.
• review?(r?): patch is under review
• review+(r+): get review+ and ready to check-in
• review-(r-): get negative review feedback. Fix problems and switch back to r? again.
• land: patch check in.
• debug: Figure out the root cause of a bug/ try to repro that bug, etc...
• file: file a bug
• PTO: take personal leave
• interview(I)
• study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
• presentation
  • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
  • WIKI/ MDN article writing.
  • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
  • Do a presentation of technical topics