TPE-Layout/2017-05-30

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

Weekly Sharing

  • Astley Chen

Weekly Status

Astley Chen

  • bug 1362255 ASSIGNED:: Make w3c-css/import-tests.py import from wpt rather than csswg-test
    • (bug 1362255) Read bug and doing assignment to follow up all possible failures.
  • bug 1362817 NEW:: Printing from FireFox 53.0 32-bit on Linux Mint 17 qiana xfce 32-bit the datetime on the page prints as 12/31/69. This is new as of my last update.
    • (bug 1362817) printing regression bug needs to be followed up.

Boris Chiou

  • bug 1346049 RESOLVED::FIXED stylo: Enable reftestts for checking stacking context in layout/reftests/web-animations
    • Landed bug 1346049 - stylo: Enable reftestts for checking stacking context in layout/reftests/web-animations
  • bug 1358266 NEW:: Intermittent transform/table-overflowed-by-animation.html | load failed: timed out waiting for pending paint count to reach zero (after reftest-wait removed and switch to print mode) (waiting for MozAfterPaint)
    • Reviewed bug 1358266 - Intermittent transform/table-overflowed-by-animation.html
  • bug 1361663 RESOLVED::FIXED stylo: The interpolated result of ServoAnimationValue is not equal to that of StyleAnimationValue
    • Landed bug 1361663 - stylo: The interpolated result of ServoAnimationValue is not equal to that of StyleAnimationValue
    • Wrote patches for bug 1361663 - stylo: The interpolated result of ServoAnimationValue is not equal to that of StyleAnimationValue
  • bug 1328503 RESOLVED::FIXED stylo: tests timeout because of using unimplemented Animation API on new window
    • Landed bug 1328503 - stylo: tests timeout because of using unimplemented Animation API on new window
  • bug 1335998 ASSIGNED:: stylo: Handle servo's interpolatematrix
    • Wrote patches for bug 1335998 - stylo: Handle servo's interpolatematrix
    • Wrote unit tests (servo) for bug 1335998 - stylo: Handle servo's interpolatematrix
  • bug 1328505 RESOLVED::FIXED stylo: test_animations_styles_on_event.html timeout waiting for animated element to trigger mouse event
    • Landed bug 1328505 - stylo: test_animations_styles_on_event.html timeout waiting for animated element to trigger mouse event
    • Reviewed bug 1328505 - Enable test_animations_styles_on_event.html on stylo
  • bug 1361938 NEW:: stylo: We don't update direction or play-state immediately in test_animations_omta.html
    • Debugged bug 1361938 - stylo: We don't update direction or play-state immediately in test_animations_omta.html
    • Reviewed bug 1361938 - stylo: We don't update direction or play-state immediately in test_animations_omta.html
  • bug 1340005 ASSIGNED:: stylo: Need a way to convert Animatable::TArrayOfTransformFunction and Animatable::Tfloat to servo's AnimationValue
    • Wrote patches for bug 1340005 - stylo: Need a way to convert Animatable::TArrayOfTransformFunction and Animatable::Tfloat to servo's AnimationValue

Cameron McCormack

  • bug 1366157 RESOLVED::FIXED stylo: Implement Window.getDefaultComputedStyle
    • Uploaded patches for bug 1366157
    • WIP on bug 1366157
  • bug 1352968 RESOLVED::FIXED stylo: Implement access to CSSImportRule
    • Reviewed bug 1352968
  • bug 1366434 RESOLVED::FIXED mask-mode and mask-composite CSS properties aren't auto-repeated for layered mask-image
    • Reviewed bug 1366434
  • bug 1367647 RESOLVED::FIXED stylo: have a way to request a restyle that recascades the entire tree
    • Uploaded patches for bug 1367647
    • WIP on bug 1367647
  • bug 1339629 RESOLVED::FIXED stylo: ServoStyleSheets don't handle modification in the presence of cloned inners correctly
    • Reviewed a few more patches in bug 1339629
  • bug 1353998 RESOLVED::FIXED Do some minimal Stylo memory reporting
    • Reviewed bug 1353998
  • bug 1366964 NEW:: Update style context generation after style resolved
    • Reviewed bug 1366964
  • bug 1367327 RESOLVED::FIXED stylo: SVG unitless length should not be rounded to absolute length during parsing and computing
    • Reviewed bug 1367327
  • bug 1367553 RESOLVED::FIXED Move stylesheets changed logic to the StyleSet.
    • Reviewed bug 1367553
  • bug 1357583 RESOLVED::FIXED stylo: Avoid triggering restyle when a stylesheet is added that can't affect the document
    • Reviewed bug 1357583
  • bug 1366921 RESOLVED::FIXED stylo: Assertion failure: NS_IsMainThread() in test_unicode_range_loading.html
    • Uploaded patch for bug 1366921
  • bug 1363968 RESOLVED::FIXED Gecko and Stylo serialize counter-{increment,reset} differently
    • Reviewed bug 1363968
  • bug 1367984 RESOLVED::FIXED stylo: refactor LoaderReusableStyleSheets to support both CSSStyleSheet and ServoStyleSheet
    • Reviewed bug 1367984
  • bug 1358993 ASSIGNED:: stylo: ServoStyleSheet::ParseSheet should disconnect child sheets / mRuleList, and re-use child sheets
    • Reviewed bug 1358993
  • bug 1363596 RESOLVED::FIXED stylo: Support symbols() function and string value for list-style-type
    • Reviewed bug 1363596
  • bug 1366735 RESOLVED::FIXED Use struct rather than nsCSSValue::Array to store counter functions
    • Reviewed some patches in bug 1366735
  • bug 1367619 RESOLVED::FIXED stylo: Use read write lock in language service
    • Reviewed bug 1367619
  • bug 1188074 RESOLVED::FIXED other values between background-clip and background-origin should allowed in background shorthand
    • Reviewed bug 1188074

CJ Ku

  • bug 1366434 RESOLVED::FIXED mask-mode and mask-composite CSS properties aren't auto-repeated for layered mask-image
    • Bug 1366434 figure out this bug
    • Bug 1366434 land patches
  • bug 1350663 RESOLVED::FIXED [css-mask] mask-image failure at position: fixed
    • Bug 1350663 figure out why my patch can not fix this bug when e10s turns on
    • Bug 1350663 land
  • bug 1367657 NEW:: CSS selector is matching twice. <svg> and <use> elements in SVG
    • Bug 1367657 analysis
  • bug 1205475 RESOLVED::FIXED nsIFrame::HasOpacityInternal takes a lot of time
    • Bug 1205475 fix type declaration error
  • bug 1351313 NEW:: Reuse nsDisplayText for frames
    • Bug 1351313 Decrypt the relation among displayitem/ARG/ASR
  • bug 1362000 RESOLVED::FIXED New graphics compositor and SVG matrixes bug
    • Bug 1362000 force land
    • Bug 1362000 land and ask for uplift
  • bug 1368234 NEW:: position:fixed inside masks is handled correctly with APZ
    • Bug 1368234 filed

Eric Tsai

Farmer Tseng

  • bug 1345789 NEW:: [Mortar] [Windows] setup an IPC between parent process and plugin process
    • Build Chromium and clarify garbage issue in Chromium, Bug 1345789
    • Figure out garbage issue , Bug 1345789
    • Implement a patch to inform nsPrintEngine, once finish printing PDF under non-e10s mode, Bug 1345789
    • Uploaded printing patch(WIP) on Bug 1345789
  • bug 1367948 NEW:: [Mortar] [pdfium] There is some garbage on EMF while converting PDF to EMF
    • Fired bug 1367948
  • bug 1359713 RESOLVED::FIXED [Mortar] [Windows] Implement LoadDocument by path in PDFiumEngineShim
    • Landed, Bug 1359713
    • Upload patch and push to try, Bug 1359713
  • bug 1362817 NEW:: Printing from FireFox 53.0 32-bit on Linux Mint 17 qiana xfce 32-bit the datetime on the page prints as 12/31/69. This is new as of my last update.
    • Reproduce the symptom, Bug 1362817

Jeremy Chen

  • bug 1360933 NEW:: Abnormal font rendering on GUI, starting with central build of 2017-03-24
    • Did a little investigation and replied the needinfo request [Bug 1360933]
  • bug 1367327 RESOLVED::FIXED stylo: SVG unitless length should not be rounded to absolute length during parsing and computing
    • Figure out the root cause and update the bug summary [Bug 1367327]
    • Filed Bug 1367327
    • Landed Bug 1367327
    • Updated patches and ask for review [Bug 1367327]
    • Uploaded wip [Bug 1367327]
  • bug 1340561 RESOLVED::FIXED stylo: figure out why layout/svg/crashtests/606914.xhtml is NOT asserting
    • Pushed a followup to help resolve [Bug 1340561]
  • bug 1365900 ASSIGNED:: stylo: Parsing for @font-feature-values
    • Updated wip and ask for feedback [Bug 1365900]
  • bug 1367977 RESOLVED::FIXED Add serialization tests for SVG unitless length values
    • Filed Bug 1367977
    • Filed spec issue, got a positive try result, uploaded patches for review [Bug 1367977]
    • Landed Bug 1367977
  • bug 1367118 ASSIGNED:: stylo: investigate the disabled SVG related tests
    • Filed Bug 1367118 and updated the current status
    • Updated status [Bug 1367118]
    • Updated status of the remaining unresloved bugs [Bug 1367118]

Louis Chang

  • bug 1367334 Use pdf name as default name of save to file in embedded pdf case
    • r+ | land
  • bug 1346682 Set title to document name for print to file
    • r+ | land
  • bug 1362255 Make w3c-css/import-tests.py import from wpt rather than csswg-test
    • WIP
  • bug 1246741 Add more test case for basic shapes clipping in SVG content
    • CJ r+ | JW r?

Shing Lyu

Ting-Yu Lin

  • bug 1363640 RESOLVED::FIXED stylo: Enable stylo for XBL documents
    • Landed bug 1363640.
  • bug 1352205 NEW:: Avoid running the refresh driver when the page is in background
    • Do some tests on major browsers for bug 1352205.
  • bug 1367286 RESOLVED::FIXED Remove preference "dom.userHTMLBindings.uri"
    • Filed and landed bug 1367286.

Tommy Kuo

  • bug 1358993 ASSIGNED:: stylo: ServoStyleSheet::ParseSheet should disconnect child sheets / mRuleList, and re-use child sheets
    • Revise patches based on heycam's feedback. (bug 1358993)
    • Upload new patches to review and test manually (bug 1358993)

Ya-Chieh Wu

  • bug 1362412 ASSIGNED:: foofighters.com is still slow to animate
    • Debug Bug 1362412

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics