TPE-Layout/2017-06-20

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

  • SFO Layout All-hands Meeting(Sched link)
    • Where: Golden Gate 4 Hilton, Lobby Level
    • When: Wednesday, June 28 • 1:15pm - 5:00pm
    • What: Each team member gives a 2-5 minute lightning talk about
      • A brief introduction.
      • What you worked on since the last All-Hands.
      • What you plan to work on next.
      • What you want to learn while you're here.
  • Labor Inspection
    • The Problems and the Acts for now.
    • Feedbacks?

Weekly Sharing

Weekly Status

Astley Chen

Boris Chiou

  • bug 1339690 RESOLVED::FIXED Drop spacing modes / paced timing
    • Landed bug 1339690 - Drop spacing modes / paced timing
    • Wrote patches for bug 1339690 - Drop spacing modes / paced timing
  • bug 1374028 RESOLVED::FIXED stylo: Remove metadata of removed/renamed WPT expectations of web-animations (spacing mode)
    • Filed bug 1374028 - stylo: Remove metadata of removed/renamed WPT expectations of web-animations (spacing mode)
    • Landed bug 1374028 - stylo: Remove metadata of removed/renamed WPT expectations of web-animations (spacing mode)
  • bug 1374233 NEW:: stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
    • Filed bug 1374233 - stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
  • bug 1369625 ASSIGNED:: stylo: stop-color, flood-color, lighting-color should be animatable
    • Wrote a patch for bug 1369625 - stylo: stop-color, flood-color, lighting-color should be animatable
    • Wrote test cases for bug 1369625 - stylo: stop-color, flood-color, lighting-color should be animatable

Cameron McCormack

  • bug 1356141 ASSIGNED:: stylo: Don't run normal traversal if only animation styles have changed
    • Reviewed bug 1356141
  • bug 1370793 RESOLVED::FIXED stylo: mochitest crash - browser_CTP_favorfallback.js
    • Landed bug 1370793
  • bug 1352306 RESOLVED::FIXED stylo: track the attributes and state that a DependencySet is sensitive to, and use it to cull snapshot creation
    • Re-landed bug 1352306 finally
  • bug 1365822 ASSIGNED:: stylo: github's search box doesn't have correct padding
    • Investigating bug 1365822
  • bug 1372549 RESOLVED::FIXED Avoid generating reflow change hint from list-style-type if display is not list-item
    • Reviewed bug 1372549
  • bug 1371708 RESOLVED::FIXED Stylo: panic loading rules for a <link> element
    • Uploaded patch for bug 1371708
  • bug 1364361 RESOLVED::FIXED stylo: AllChildrenIterator doesn't find NAC created by non-primary frames of elements
    • Landed bug 1364361
  • bug 1354879 RESOLVED::FIXED stylo: Properly support generated content for display: contents.
    • Landed bug 1354879
    • Uploaded patch for bug 1354879
  • bug 1359217 RESOLVED::FIXED Stylo: Opening DevTools inspector crashes during `inDOMUtils::GetCSSStyleRules`
    • Reviewed bug 1359217
  • bug 1368236 RESOLVED::FIXED stylo: Plan for killing RestyleData.
    • Reviewed one patch of bug 1368236
  • bug 1371955 RESOLVED::FIXED stylo: Figure out why we reflow the whole document when restyling the HTML spec when we shouldn't.
    • Reviewed bug 1371955
  • bug 1373874 ASSIGNED:: stylo: two tests started leaking rule nodes over the last week
    • Uploaded patch for bug 1373874
  • bug 1372068 NEW:: stylo: Don't traverse the whole subtree if there are no dependencies from stylesheets.
    • Reviewed bug 1372068
  • bug 1373155 RESOLVED::FIXED stylo: disable Web Components in Servo-styled documents
    • Landed bug 1373155
  • bug 1370802 RESOLVED::FIXED stylo: consider storing xml:lang="" and lang="" attributes as atoms
    • Reviewed bug 1370802
  • bug 1372089 RESOLVED::FIXED stylo: WPT WebVTT tests failing
    • Uploaded patch for bug 1372089
  • bug 265894 ASSIGNED:: Support SVG CSS selector matching rules for <svg:use>
    • Reviewed bug 265894

CJ Ku

  • Study https://w3c.github.io/webcomponents/spec/shadow/
  • bug 1371267 RESOLVED::FIXED Facebook's volume bar glitches when hovering over the volume button
    • Bug 1371267 r?
  • bug 1372879 NEW:: Implement symbol::refX and symbol::refY attribute
    • Bug 1372879 filed
  • bug 1372537 NEW:: In svg.css, change the display rule of symbol element from "none" to "none !important"
    • Bug 1372537 filed
  • bug 265894 ASSIGNED:: Support SVG CSS selector matching rules for <svg:use>
    • Bug 265894 rework patches base on heycam's comment
    • Bug 265894 update patches

Eric Tsai

Farmer Tseng

  • bug 1372108 ASSIGNED:: Add support for having Save-as-PDF use Skia PDF on Windows
    • F+, uploaded patch to Bug 1372108
    • Filed Bug 1372108
    • Uploaded patch to Bug 1372108, f?
    • Uploaded patch to Bug 1372108, r?
  • bug 1372113 ASSIGNED:: Stop finding the function symbols in PDFiumEngineShim
    • F+, uploaded patch to Bug 1372113
    • Filed Bug 1372113
    • Uploaded patch and f? on Bug 1372113
    • Uploaded patch to Bug 1372113, r?
  • bug 1369302 ASSIGNED:: [SkiaPDF] Crash in DWriteFontTypeface::onGetAdvancedTypefaceMetrics(), fDWriteFontFamily is nullptr
    • Updated the divergence between Skia PDF and normal text rendering on Bug 1369302
    • Uploaded patch to Bug 1369302, f?
  • bug 1370488 ASSIGNED:: Add support for having printing on Windows print via Skia PDF and PDFium
    • F?, uploaded patch to Bug 1370488
    • Fixed running browser_DownloadPDFSaver.js failure and updated try result on Bug 1370488
    • Uploaded patch and f? on Bug 1370488
    • Uploaded patch to Bug 1370488, r?

Jeremy Chen

  • bug 1365900 ASSIGNED:: stylo: Parsing for @font-feature-values
    • Studied Simon's feedback, reworked wip [Bug 1365900]
    • Study stylo's @keyframes implementation, for nested declaration parsing reference [Bug 1365900]
  • bug 1356134 RESOLVED::FIXED stylo: implement font-variant shorthand property
    • Got a green try and ask for review [Bug 1356134]
    • Landed Bug 1356134
  • bug 1369321 ASSIGNED:: stylo: Viewport scrollbar should not be zoomed while zooming the whole content document
    • A bit more investigation, ni bz for comments [Bug 1369321]

Louis Chang

  • bug 1319407 clip-path reference-box geometry computing should respect box-decoration-break
    • WIP

Shing Lyu

Stylo

  • Bug 1372821 - -webkit-linear-gradient is wrong in servo
  • Bug 1366050 - linux32 build on CI
  • Analyzing Alexa results
  • PyCon sharing preparation

Ting-Yu Lin

  • bug 1367345 RESOLVED::DUPLICATE stylo: Textarea's resizer is not showing up
    • Resolve bug 1367345 and bug 1370830 as duplicate.
  • bug 1372062 NEW:: stylo: Stylo does not render button with a custom background correctly (styloVsGecko reftest)
    • Debug bug 1372062.
    • Uploaded patches for bug 1372062.
  • bug 1370830 RESOLVED::DUPLICATE stylo: ASSERTION: NS_BLOCK_HAS_FIRST_LETTER_STYLE state out of sync
    • Resolve bug 1367345 and bug 1370830 as duplicate.
  • bug 1371577 RESOLVED::FIXED stylo: warning: Reframing due to lack of old style source: <resizer>
    • Landed bug 1371577.
    • Uploaded patches for bug 1371577.
  • bug 1321769 RESOLVED::WORKSFORME stylo: scrollbars don't work
    • Close bug 1361297 and bug 1321769 as works for me.
  • bug 1361297 RESOLVED::WORKSFORME stylo: AccessibleCaret doesn't work
    • Close bug 1361297 and bug 1321769 as works for me.

Tommy Kuo

  • bug 1373159 NEW:: stylo: make `-moz-context-properties` support `fill-opacity` and `stroke-opacity` values
    • WIP (bug 1373159)
  • bug 1370797 ASSIGNED:: stylo: context-fill / context-stroke are not working when using SVG as an image on stylo
    • R? (bug 1370797)
    • Trace code for svg-as-image (bug 1370797)

Ya-Chieh Wu

  • bug 1362412 ASSIGNED:: foofighters.com is still slow to animate
    • Bug 1362412 upload debug files
  • bug 1362873 ASSIGNED:: Drag selection(word by word selection) is broken if input is there
    • Debug Bug 1362873
    • Land Bug 1362873
  • bug 1370833 RESOLVED::FIXED make less *InvalidateTableFrame* calls so we won't over painting the table.
    • Land Bug 1370833
  • bug 1335476 ASSIGNED:: Inputs are invisible (black on black) when changing colour settings
    • Debug Bug 1335476

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics