TPE-Layout/2017-07-18

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

  • Q3 offsite meeting
    • Date/Venue/Agenda

Weekly Sharing

  • Farmer Tseng
    • Gecko Printing Tests

Weekly Status

Astley Chen

  • Start Stylo dogfooding on macOS nightly. <o^.^o>
  • bug 1357004 NEW:: Crash in nsTHashtable<T>::s_HashKey | mozilla::FramePropertyTable::GetInternal
    • Triaged bug 1357004 - P5, 2 occurrences only for last 3 months.
  • bug 1377253 ASSIGNED:: Reflow is slow on twitter direct messages (with reflow time mostly spent in nested flex reflow)
    • Triaged bug 1377253 - qf:p1
  • bug 1377188 ASSIGNED:: Change the UA 'box-sizing' style to 'content-box' for hr element.
    • Triaged bug 1377188 - seems a good-first-bug
  • bug 1303601 NEW:: CSS parallax content doesn't repaint when resizing window
    • Triaged bug 1303601 as P3
  • bug 1301954 NEW:: Firefox crashes in [@ IsZeroSize ]
    • Triaged bug 1301954 - p3
  • bug 1300384 ASSIGNED:: http://www.evil-bikes.com/ does not render correctly.
    • Triaged bug 1300384 - parity-chrome
  • bug 1296232 NEW:: Negative letter-spacing + soft hyphen = broken layout
    • Triaged bug 1296232 - parity-chrome:p2
  • bug 1287512 RESOLVED::DUPLICATE Some SVG images do not print, even though they display in print preview
    • Traiged bug 1287512 - printing issue and could be fixed by new parinting backend
  • bug 1294631 NEW:: content-box overlap with padding-box
    • Triaged bug 1294631 - parity-chrome:p2
  • bug 1348857 RESOLVED::FIXED [css-grid] Intristic content with overflow:auto overlaps in grid
    • (bug 1319688) resolved dupe of bug 1348857
    • (bug 1348857) resolved dupe of bug 1348857
    • (bug 1348857) resolved dupe of bug 1348857
  • bug 1367214 ASSIGNED:: Frame destruction does unconditional hashtable lookups in the undisplayed map (in nsFrameManager::ClearAllMapsFor)
    • Triaged bug 1367214 - qf:p1
  • bug 1280310 NEW:: Negative margin renders incorrectly when zooming the page
    • Triaged bug 1280310 - parity chrome
  • bug 1319688 RESOLVED::DUPLICATE [css-grid] Scroll auto not working on a fixed size track
    • (bug 1319688) resolved dupe of bug 1348857
    • Triage bug 1319688
  • bug 1362758 ASSIGNED:: Flexbox layout does not update properly after content changes
    • Triaged bug 1362758 - regression:p2
  • bug 1356114 ASSIGNED:: hr with 1px border-width and dashed style is not evenly spaced
    • Triaged bug 1356114 - webcompat:p1
  • bug 1352205 ASSIGNED:: Avoid running the refresh driver when the page is in background
    • Triaged bug 1352205 - qf:p2
  • bug 1365783 ASSIGNED:: Deleting frames under nsCSSFrameConstructor::ContentRemoved() can be really expensive
    • Triaged bug 1365783 - qf:p1

Boris Chiou

  • PTO 7/3 ~ 7/14

Cameron McCormack

  • Reviewed https://github.com/servo/servo/pull/17707
  • Reviewed https://github.com/servo/servo/pull/17713
  • Reviewed https://github.com/servo/servo/pull/17716
  • Reviewed https://github.com/servo/servo/pull/17751
  • bug 1380800 RESOLVED::FIXED stylo: Crash in InvalidArrayIndex_CRASH | nsTArray_Impl<T>::ElementAt | mozilla::ServoCSSRuleList::GetRule
    • Reviewed bug 1380800
  • bug 1379505 RESOLVED::FIXED stylo: Isolate style resolution to avoid bugs like bug 1379041
    • Reviewed remaining patches in bug 1379505
  • bug 1376406 VERIFIED::FIXED rxviz.com is broken: Need to click button 2 or 3 times to make things happen
    • Landed bug 1376406
  • bug 1377993 NEW:: Make node slots less memory hungry in common cases
    • Reviewed a patch in bug 1377993
  • bug 1379464 RESOLVED::FIXED Enable context paint for moz-extension:// images
    • Reviewed bug 1379464
  • bug 1379865 NEW:: stylo: don't perform parent display-based style fixups on pseudos except ::before/::after
    • Uploaded patch for bug 1379865
  • bug 1380488 VERIFIED::FIXED Stylo: Gmail crash in alloc::oom::default_oom_handler | alloc::oom::oom
    • Reviewed bug 1380488
  • bug 1366964 RESOLVED::FIXED Update style context generation after style resolved
    • Final review of bug 1366964
  • bug 1348488 RESOLVED::FIXED stylo: support parsing ::-moz-tree-* pseudo-elements
    • Reviewed bug 1348488
  • bug 1380258 NEW:: stylo: site issue: FastMail refresh animation continues running after it shouldn't
    • Filed bug 1380258 with a reduced test
  • bug 1380106 RESOLVED::FIXED stylo: Crash in do_QueryFrame::operator<T> nsIAnonymousContentCreator*
    • Reviewed bug 1380106
  • bug 1380789 RESOLVED::FIXED stylo: Uplift a few assertions to nightly
    • Reviewed bug 1380789
  • bug 1380133 ASSIGNED:: stylo: HackerRank menu hover animation flickers
    • Start working on bug 1380133
    • Uploaded new WIP patches for bug 1380133
  • bug 1379901 NEW:: stylo: Socorro Super Search page's form fields are aligned vertically instead of horizontally
    • Produced reduced test case for bug 1379901
    • Reviewed bug 1379901
  • bug 1381323 RESOLVED::FIXED The ExpectedOwnerForFrame assertion doesn't account for text frames.
    • Reviewed bug 1381323
  • bug 1376964 RESOLVED::FIXED stylo: Avoid the additional restyle for user font if the font can be loaded synchronously (e.g. from cache)
    • Landed bug 1376964
    • Update patches for bug 1376964
  • bug 1380224 RESOLVED::FIXED stylo: Microsoft Edge "Custom Properties Pooch" demo does not switch background image when Stylo is enabled
    • Produced reduced test case for bug 1380224
    • Uploaded patches for bug 1380224

CJ Ku

  • bug 1378710 ASSIGNED:: SVG: mask renders incorrectly when clipped group has animated contents
    • Bug 1378710 r?
    • Bug 1378710 update patch
  • bug 1363140 NEW:: [e10s] SVG image set using content:url(...) bounces around when changing its opacity on hover
    • Bug 1363140 I tried... I gave up
    • Bug 1363140 take a look
  • bug 1381503 NEW:: Fine tune nsDisplayListBuilder::GetWidgetLayerManager
    • Bug 1381503 filed and upload patches
  • bug 1379404 RESOLVED::FIXED Fine tune text painting
    • Bug 1379404 landed
  • bug 1377329 RESOLVED::FIXED nsFrameList::GetLength() calls in nsDisplayListBuilder::MarkFramesForDisplayList() are slow
    • Bug 1377329 upload a patch
  • bug 1351313 NEW:: Reuse nsDisplayText for frames
    • Bug 1351313 post comment, I still see no reason to reuse text display item.
    • Bug 1351313 upload a patch

Eric Tsai

  • Issue triage
  • Alexa Top Site API security requirement survey with IT team
    • Satisfied: HTTPS request
    • Not satisfied: only root credential, no IAM credential. Follow up: RRA meeting
  • Prototype dependency diagram of webcompat.com issue and bugzilla bug

Farmer Tseng

  • bug 1379124 RESOLVED::WONTFIX 3.57% tp5n main_startup_fileio (windows7-32) regression on push d890f9fc0b5c96c3583b920f73acd0dbb1f51526 (Thu Jul 6 2017)
    • Did some experiments and updated on Bug 1379124
  • bug 1380301 RESOLVED::FIXED Perma Bustage when Gecko moves to 56 in nsDeviceContextSpecWin.h(30): error C2039: 'PDFViaEMFPrintHelper': is not a member of 'mozilla::widget'
    • Tried, uploaded patches, landed on Bug 1380301
  • bug 1358076 ASSIGNED:: [PDF gtest] Implement unit test for PDFViaEMFPrintHelper
    • Uploaded patch, f? on Bug 1358076
  • bug 1358985 RESOLVED::DUPLICATE [Mortar] [Windows] handle multiple PDF printing with PDFium lib simultanously
    • (bug 1358985) resolved duplicate of bug 1372113
  • bug 1349139 RESOLVED::DUPLICATE [Mortar] Replace PDFium defines with an appropriate include once the PDFium source has landed in the tree
    • (bug 1349139) resolved duplicate of bug 1372113
  • bug 1372113 RESOLVED::FIXED Stop finding the function symbols in PDFiumEngineShim
    • (bug 1349139) resolved duplicate of bug 1372113
    • (bug 1358985) resolved duplicate of bug 1372113
  • bug 1367948 ASSIGNED:: There is some garbage on EMF while converting PDF to EMF
    • Uploaded patch and f? on Bug 1367948

Jeremy Chen

  • bug 1381232 NEW:: consider serialize computed <number-percentage> values to <number> values for filter property
    • Filed Bug 1381232
    • Uploaded a wip, though not sure if this is urgent since this might not be a stylo issue anymore [bug 1381232]
  • bug 1355991 NEW:: Focus outline performs outline-width transition from 3px to 1px once element is focused (if transition is set)
    • Investigated further, discussed with Cameron, and NI dbaron for the approaches so far [Bug 1355991]
    • Replied ni? for bug 1355991
    • Un-asign myself due to dbaron's feedback [bug 1355991]
  • bug 1374513 RESOLVED::FIXED stylo: filter serialization is different
    • Investigated, hacked, and came up with a better approach per discussed w/ heycam [bug 1374513]
  • bug 1381196 NEW:: stylo: Yelp's thumbnail images shake and rotate when mousing over then instead of
    • Did an initial investigation [Bug 1381196]
    • Uploaded a reduced testcase [Bug 1381196]

Louis Chang

  • bug 1352238 - Implement a native theme for checkbox/radio form controls on Android
    • f+mconley, f?snorp
  • bug 1319407 - clip-path reference-box should respect box-decoration-break
    • WIP

Shing Lyu

Stylo

Servo

  • Study Servo embedding story
  • Allow configuring overscroll behavior on all sides

Evangelism

  • HackNTU A-frame demo
  • SITCON
  • COSCUP

Ting-Yu Lin

  • bug 1379001 NEW:: Long CC times when Facebook group navigation start: group first item is displayed
    • Replied needinfo for bug 1379001.
  • bug 1381017 NEW:: stylo: After dynamically modifying an element with -moz-binding, frames do not created under <xbl:children>
    • Filed bug 1381017.
    • Uploaded patches for bug 1381017.
  • bug 1380567 RESOLVED::FIXED Remove RestyleManagerHandle
    • Filed and landed bug 1380567

Tommy Kuo

  • bug 1377158 NEW:: stylo: Enable stylo for SVG-as-an-image.
    • Finish patches and run a try (bug 1377158)
    • Fixed the try failures and uploaded patches to ask review. (Bug 1377158)
  • bug 1380590 NEW:: stylo: the fill color should be transparent when `svg.context-properties.content.enabled` and no fallback color given
    • Filed (bug 1380590)

Ya-Chieh Wu

  • bug 1375518 ASSIGNED:: Border radius is not painted correctly on border-collapsed table-cell elements
    • Trace code for Bug 1375518

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics
Retrieved from "https://wiki.mozilla.org/index.php?title=TPE-Layout/2017-07-18&oldid=1175918"