TPE-Layout/2017-07-25
From MozillaWiki
Contents
Weekly Announcement
- Offsite on 7/27 (10AM~6PM), break down into 3 sessions.
- Weekly update - round table + sharing
- Team status, individual topics, and Q&A.
- Peer programming and hacking.
Weekly Sharing
Weekly Status
Astley Chen
- bug 1378455 NEW:: Regression in behaviour of async-scrolling offscreen scrollbar thumb inside iframe
- (bug 1378455) nightly only, update 55 flag to unaffected.
Boris Chiou
- bug 1374233 ASSIGNED:: stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
- Re-wrote patches for bug 1374233, according to the discussion with nox
- Re-wrote patches for vector-like properties, filter, and shadow, for bug 1374233.
- Wrote patches for bug 1374233 - stylo: Clamp negative interpolated values for non-negative properties while using negative timing functions
Cameron McCormack
- Reviewed https://github.com/servo/servo/pull/17796
- bug 1376248 RESOLVED::FIXED stylo: Records by animation observer seem to be split into several entries
- Uploaded patches for bug 1376248
- bug 1377115 RESOLVED::FIXED stylo: re-enable layout/style/test/test_variables.html
- Reviewed bug 1377115
- bug 1382547 RESOLVED::DUPLICATE make crash signatures include stack frame past very common rust unwrapping functions
- Filed bug 1382547
- bug 1382593 RESOLVED::FIXED Cleanup a bit nsImageMap.
- Reviewed bug 1382593
- bug 1383296 NEW:: Remove the nsCSSValue::Serialization enum and remove decision logic in functions that use it
- Reviewed bug 1383296
- bug 1381471 RESOLVED::FIXED Refactor implementations of gfxPlatform::IsFontFormatSupported
- Reviewed bug 1381471
- bug 1377158 NEW:: stylo: Enable stylo for SVG-as-an-image.
- Reviewed bug 1377158
- bug 1383001 RESOLVED::FIXED stylo: Crash in mozalloc_abort | abort | style::context::ElementCascadeInputs::new_from_element_data
- Reviewed bug 1383001
- bug 1381233 VERIFIED::FIXED stylo: crash when page involves an embed and external stylesheet
- Reviewed bug 1381233
- bug 1371150 RESOLVED::FIXED stylo: Support negative opacity for SMIL
- Uploaded patches for bug 1371150
- bug 1382080 RESOLVED::FIXED stylo: Fix the rest of failure in test_system_font_serialization.html
- Reviewed bug 1382080
- bug 1382189 RESOLVED::FIXED [Form Autofill] Setting manuallyManagedState bit might trigger frame re-construction and erase the preview text while previewing
- Reviewed bug 1382189
- bug 1380133 RESOLVED::FIXED stylo: HackerRank menu hover animation flickers
- Fixed and re-landed bug 1380133
- Uploaded patches for review for bug 1380133
- Uploaded rebased WIP patches to bug 1380133
- bug 1382357 RESOLVED::FIXED stylo: Crash in GetInnerText/IsOrHasAncestorWithDisplayNone with AdBlock Plus enabled
- Reviewed bug 1382357
- bug 1381682 RESOLVED::FIXED stylo: mozreview debug_assertion failure: pseudos can't generate sibling invalidations...
- Reviewed bug 1381682
- bug 1366721 RESOLVED::FIXED stylo: Restyle additional style contexts
- Reviewed bug 1366721
- bug 1381731 NEW:: stylo: Assertion failure: removedCount <= gUnusedAtomCount, at /home/ikezoe/central/xpcom/ds/nsAtomTable.cpp:432
- Trying and failing to reproduce some frame-related stylo crash bugs. :( but did analyze the bug 1381731 assertion.
- bug 1371493 RESOLVED::FIXED stylo: Servo_GetComputedKeyframeValues does not respect property ordering
- Reviewed one patch of bug 1371493
CJ Ku
- bug 1382257 VERIFIED::FIXED Rendering issues for phonebook
- Bug 1382257 land
- Bug 1382257 push followup
- Bug 1382257 upload patch
- Bug 1382257r+
- bug 1381503 RESOLVED::FIXED Fine tune nsDisplayListBuilder::GetWidgetLayerManager
- Bug 1381503 landed
- bug 1319407 RESOLVED::FIXED clip-path reference-box geometry computing should respect box-decoration-break
- Bug 1319407 reviewed
- bug 1383650 NEW:: Implement SVG geometry properties in CSS
- Bug 1383650 filed
- bug 1379530 NEW:: Cache ScaledFontFontconfig
- Bug 1379530 upload patch
- bug 1301245 ASSIGNED:: stop trying to load SVG mask references as images
- Bug 1301245 upload patch
- bug 1378710 RESOLVED::FIXED SVG: mask renders incorrectly when clipped group has animated contents
- Bug 1378710 r+ and landed
- Bug 1378710 request uplift
- bug 1381593 RESOLVED::FIXED Update pdf.js to version 1.8.557
- Bug 1381593 landed
- bug 1382909 NEW:: Enable prerendering/OMTA for masked element
- Bug 1382909 filed
Eric Tsai
- Issue triage
- Rewrite https://mdtsai.github.io/wc-bz.html with cytoscape.js for better performance
- Write a medium blog post for wc-bz.html https://medium.com/@md.tsai/%E8%A6%96%E8%A6%BA%E5%8C%96-webcompat-issue-%E7%9A%84%E7%9B%B8%E9%97%9C%E6%80%A7-2bfea1c3aa5
- Survey works and impact to move status from github label to milestone
Farmer Tseng
- bug 1382509 ASSIGNED:: Pull out PDFium from xul
- Filed Bug 1382509
- Uploaded patches on Bug 1382509
- bug 1382512 ASSIGNED:: [PDF gtest] convert EMF to bitmap and compare the bitmap content with reference
- Filed bug 1382512
- bug 1358076 ASSIGNED:: [PDF gtest] Implement unit test for PDFViaEMFPrintHelper
- Dump GDI command from EMF file and compare reference one, Bug 1358076
- Refactored patch and uploaded on Bug 1358076
- Uploaded patch, pushed to try, f? on Bug 1358076
Jeremy Chen
- bug 1381386 ASSIGNED:: stylo: Crash in mozalloc_abort | abort | style::properties::Template:Impl::to_css<T>
- Replied ni? and ask for more info [Bug 1381386]
- bug 1380957 NEW:: stylo: Twitter ad not styled correctly
- Took a shot but failed to reproduce the issue, left comment about the findings [Bug 1380957]
- bug 1382517 RESOLVED::FIXED stylo: Add automation tests for 3D transform matrix decomposition
- Filed Bug 1382517
- Landed Bug 1382517
- Uploaded a patch and asked for review [Bug 1382517]
- bug 1382742 REOPENED:: stylo: site issue: Broken hover transition
- Triaged stylo real site bugs and closed Bug 1381670 and Bug 1382742
- bug 1381196 VERIFIED::FIXED stylo: Yelp's thumbnail images shake and rotate when mousing over then instead of
- Found the root cause, uploaded a patch, ask for review [Bug 1381196]
- Landed Bug 1381196
- Traced CSSTransitions for transform property code path for stylo, narrowed the scope of the possible root causes [Bug 1381196]
- bug 1381670 RESOLVED::DUPLICATE stylo: transition doesn't work correctly presumably because of pseudo-elements
- Triaged stylo real site bugs and closed Bug 1381670 and Bug 1382742
- bug 1382956 RESOLVED::FIXED stylo: ease the hazard tolerance number for Bug 1380133
- Filed, landed, backed out, relanded [Bug 1382956]
- bug 1381235 ASSIGNED:: stylo: issue with transitioning on visited links
- Uploaded a reduced testcase [Bug 1381235]
- bug 1372266 NEW:: stylo: consider returning 'InvalidValue' error while parsing invalid values
- Lower the priority and un-assign myself [Bug 1372266]
Louis Chang
- bug 1319407 - clip-path reference-box geometry computing should respect box-decoration-break
- Land
- bug 1381201 - SVG: Incorrect behavior when transitioning a transform
- Study
- bug 1380924 - [Meta] Triage remaining or new failures in failure.list for importing wpt test
- file bug 1380924 - [Meta] Triage remaining or new failures in failure.list for importing wpt test
- file bug 1383008 - ch unit is wrong in vertical mixed
- file bug 1383600 - Fix sizing-orthog-* tests failures
Shing Lyu
Ting-Yu Lin
- bug 1381851 ASSIGNED:: Stylo: Flash click to play doesn't display on video elements when Stylo is enabled
- Debug bug 1381851.
- bug 1381017 RESOLVED::FIXED stylo: After dynamically modifying an element with -moz-binding, frames do not created under <xbl:children>
- Landed bug 1381017.
Tommy Kuo
- Revise patches according to reviewer's comment
- bug 1377158 NEW:: stylo: Enable stylo for SVG-as-an-image.
- Finished the patch to consider style backend type into the hash function of image cache and uploaded to ask to review. (bug 1377158)
- Fix compilation error (bug 1377158)
- Fix the tab crash and upload patches to ask review (bug 1377158)
- Revise patch according to reviewer's comment and run a try (bug 1377158)
- Revise patches according to reviewer's comment (bug 1377158)
Ya-Chieh Wu
- bug 1379306 ASSIGNED:: Position absolute not work as expected in table with border collapse
- Debug 1379306
- Debug bug 1379306
- bug 1375518 ASSIGNED:: Border radius is not painted correctly on border-collapsed table-cell elements
- Bug 1375518 r?
Rule of Thumb
Status code:
- OOAD: In analysis or design phase.
- WIP: working on WIP patch.
- feedback(f): feedback a patch
- feedback?(f?): WIP is ready for feedback grant.
- feedback+(f+): Get positive feedback.
- feedback-(f-): Get negative feedback.
- review(r): review a patch.
- review?(r?): patch is under review
- review+(r+): get review+ and ready to check-in
- review-(r-): get negative review feedback. Fix problems and switch back to r? again.
- land: patch check in.
- debug: Figure out the root cause of a bug/ try to repro that bug, etc...
- file: file a bug
- PTO: take personal leave
- interview(I)
- study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
- presentation
- Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
- WIKI/ MDN article writing.
- If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
- Do a presentation of technical topics