TPE-Layout/2017-11-21

From MozillaWiki
Jump to: navigation, search

Weekly Announcement

Weekly Sharing

Weekly Status

Astley Chen

  • bug 1414789 NEW:: 4.74 - 10.73% dromaeo_css (linux64, osx-10-10, windows10-64, windows7-32) regression on push ab10dee6754602dc43038618032c2a6b06396661 (Sat Nov 4 2017)
    • Bug 1414789 - perf regression on Dromaeo CSS test suite, need further investigation.

Boris Chiou

  • bug 1408310 ASSIGNED:: make WebKitCSSMatrix use Servo for parsing transform lists
    • Fixed a bug of nsCSSParser while paring transform property for bug 1408310
    • Fixed test failures for bug 1408310
    • Updated DOMMatrix::SetMatrixValue for stylo for bug 1408310 - make WebKitCSSMatrix use Servo for parsing transform lists
    • Wrote patches for bug 1408310 - make WebKitCSSMatrix use Servo for parsing transform lists

Cameron McCormack

  • Submitted https://github.com/mozilla/readability/pull/406
  • Submitted https://github.com/servo/rust-cssparser/pull/203
  • bug 1180145 NEW:: Resource timing violate SOP for "no-cors" CSS
    • Reviewed bug 1180145
  • bug 1416564 RESOLVED::FIXED Try to remove the mozmm CSS unit
    • Reviewed bug 1416564
  • bug 1417837 NEW:: de-scope the style sheets in aboutReader.html
    • Uploaded patch for bug 1417837
  • bug 1418456 RESOLVED::FIXED stylo: Cleanup the XBL binding style resolution stuff.
    • Reviewed bug 1418456
  • bug 1418560 RESOLVED::FIXED Properly return null from GetFlattenedTreeParent if the node is XBL fallback content.
    • Reviewed bug 1418560
  • bug 1418216 RESOLVED::FIXED move IsCSSSheetType out of nsStyleSet
    • Uploaded patches for bug 1418216, bug 1418217, and bug 1418222
  • bug 1418232 RESOLVED::FIXED move pseudo-class matching helper methods from nsCSSRuleProcessor to nsCSSPseudoClasses
    • Uploaded patch for bug 1418232
  • bug 1418217 RESOLVED::FIXED move visited links pref to StylePrefs
    • Uploaded patches for bug 1418216, bug 1418217, and bug 1418222
  • bug 1418872 RESOLVED::FIXED move ControlCharVisibilityDefault() out of nsCSSParser
    • Uploaded patch for bug 1418872
  • bug 1418222 RESOLVED::FIXED move system metrics handling from nsCSSRuleProcessor to nsMediaFeatures
    • Uploaded patches for bug 1418216, bug 1418217, and bug 1418222
  • bug 1418905 ASSIGNED:: Move nsRuleNode::ComputeComputedCalc() and nsRuleNode::ComputeCoordPercentCalc() to nsStyleCoord
    • Reviewed bug 1418905
  • bug 1417924 RESOLVED::FIXED Remove style scoped stuff from some display: contents reftests
    • Reviewed bug 1417924
  • bug 1417841 RESOLVED::FIXED The textpath has an offset x, the offset is shown on Chrome and Edge but not Firefox
    • Uploaded patch for bug 1417841
  • bug 1417701 RESOLVED::FIXED MotionMark Focus20 spends a bunch of time in nsIFrame::DoUpdateStyleOfOwnedAnonBoxes
    • Reviewed bug 1417701
  • bug 1418899 ASSIGNED:: move some static methods out of nsRuleNode
    • Uploaded patches for bug 1418899
  • bug 1417281 RESOLVED::FIXED stylo-chrome: Window is not restyled correctly immediately after changing theme
    • Reviewed bug 1417281
  • bug 1345688 ASSIGNED:: stylo: align binary representations of computed keyword values and eliminate the match statements
    • Uploaded WIP patch for bug 1345688

CJ Ku

  • bug 1309046 NEW:: SVG with external content via <use> does not print
    • Bug 1309046 investigate
    • Bug 1309046 upload a patch
  • bug 1399787 NEW:: Create a new sandboxed process to run pdfium
    • Bug 1399787 fix issues and update

Eric Tsai

  • Issue triage
  • WebCompat-Bugzilla dependency graph https://webcompat.herokuapp.com/wc-bz.html
    • Fix the period input
    • Tune the layout, highlight important issue/bug
    • Rewrite some UI by jQueryUI
  • WebCompat.com bug report form improvement
    • Connect github search API for searching URL

Jeremy Chen

  • bug 1415581 RESOLVED::FIXED German hyphenation is wrong, single letter teared off
    • Debug Bug 1415581
    • Figured out the root cause and uploaded a patchset [Bug 1415581]
    • Landed Bug 1415581
    • Requested uplift to beta [Bug 1415581]
    • Updated patchset, got positive try, asked for review [Bug 1415581]
  • bug 1387176 RESOLVED::FIXED Switch nsFrameSelection to use either an initializer list or per-member defaults
    • Landed Bug 1387176
    • Uploaded patchset for review [Bug 1387176]
  • bug 1411798 UNCONFIRMED:: Web Console Shows CSS Errors for Unrecognized Properties in @supports Rules
    • Pass by and investigate a bit Bug 1411798

Louis Chang

  • bug 1246836 - -moz-appearance button should behave like -webkit-appearance: button
    • WIP
  • bug 1417751 - Implement -moz-appearance: inner-spin-button which behave like -webkit-appearance: inner-spin-button
    • WIP
  • bug 1406268 - Handle clamping width/height of checkbox/radio on Linux
    • land

Ting-Yu Lin

  • bug 1418222 RESOLVED::FIXED move system metrics handling from nsCSSRuleProcessor to nsMediaFeatures
    • Reviewed bug 1418222.
  • bug 1387176 RESOLVED::FIXED Switch nsFrameSelection to use either an initializer list or per-member defaults
    • Reviewed bug 1387176.
  • bug 1418872 RESOLVED::FIXED move ControlCharVisibilityDefault() out of nsCSSParser
    • Reviewed bug 1418872 and bug 1418899
  • bug 1418217 RESOLVED::FIXED move visited links pref to StylePrefs
    • Reviewed bug 1418180, bug 1418217, and bug 1418216
  • bug 1418216 RESOLVED::FIXED move IsCSSSheetType out of nsStyleSet
    • Reviewed bug 1418180, bug 1418217, and bug 1418216
  • bug 1416962 RESOLVED::FIXED Remove support to disable 'click and drag' text selection for touch enable devices
    • Filed and landed bug 1416962
  • bug 1417796 RESOLVED::FIXED Fix warning generated by static-analysis for AccessibleCaret
    • Filed and uploaded patches for bug 1417796
    • Landed bug 1417796.
  • bug 1418899 ASSIGNED:: move some static methods out of nsRuleNode
    • Reviewed bug 1418872 and bug 1418899
  • bug 1417376 RESOLVED::FIXED Convert nsPoint parameters to passing by const reference instead values
    • Filed and uploaded patches for bug 1417376
    • Landed bug 1417376.
  • bug 1286882 REOPENED:: Tapping SVG shape invokes text selection UI
    • Debug bug 1286882.
  • bug 1418905 ASSIGNED:: Move nsRuleNode::ComputeComputedCalc() and nsRuleNode::ComputeCoordPercentCalc() to nsStyleCoord
    • Filed and uploaded patches for bug 1418905.
  • bug 1418180 RESOLVED::FIXED Add parent information into the output of the frame tree.
    • Reviewed bug 1418180, bug 1418217, and bug 1418216

Tommy Kuo

  • Try to make nsListControlFrame be an out-of-flow frame
  • bug 1418180 RESOLVED::FIXED Add parent information into the output of the frame tree.
    • File & land (Bug 1418180)

Ya-Chieh Wu

  • bug 1405929 NEW:: [BC] rowspan on border-collapse is wrong.
    • Debug Bug 1405929
    • R? bug 1405929

Rule of Thumb

Status code:

  • OOAD: In analysis or design phase.
  • WIP: working on WIP patch.
  • feedback(f): feedback a patch
  • feedback?(f?): WIP is ready for feedback grant.
  • feedback+(f+): Get positive feedback.
  • feedback-(f-): Get negative feedback.
  • review(r): review a patch.
  • review?(r?): patch is under review
  • review+(r+): get review+ and ready to check-in
  • review-(r-): get negative review feedback. Fix problems and switch back to r? again.
  • land: patch check in.
  • debug: Figure out the root cause of a bug/ try to repro that bug, etc...
  • file: file a bug
  • PTO: take personal leave
  • interview(I)
  • study: Spend time on domain knowledge study, such as multimedia transport technology, compress format, real-time rendering.
  • presentation
    • Write a personal blog, which is relative to work, such as articles on MozTech, or what you experience in a work week.
    • WIKI/ MDN article writing.
    • If you write a technical blog or anything relative to work, it's welcome to share it on weekly report.
    • Do a presentation of technical topics