User:Bwinton/Review Checklist
From MozillaWiki
Review Checklist.
General
hg import --no-commit "<patch url>"
Does it apply?
make -f client.mk
Does it build?
cd ..\<objdir> make mozmill make xpcshell-tests make check
Does it pass all the tests?
Sometimes you can run a subset with one of the following:
make SOLO_TEST=folder-display mozmill-one make SOLO_TEST=folder-display/test-message-window.js mozmill-one make SOLO_FILE="test_attachmentChecker.js" -C mail/base/test/ check-one
Make sure there's a test included which fails without the patch, but passes with the patch.
Since there's a test, make sure the test uses "accelKey" in place of "ctrlKey".
Javascript
Does it pass http://beaufour.dk/jst-review/?patch=<patch url>&file=
Check function arguments (start with 'a', documented in header).
Manifest
To be filled in.
CSS
To be filled in.